Repository navigation
S06: installed smoke candidate - Benchmark producers in the payload - #66
Merged
michaldengusiak merged 12 commits intoOct 20, 2026
Merged
Conversation
…S06) Run Simulation > Both runs benchmark-tas.exe and benchmark-openstudio.exe from beside SAM Analytical.exe, but no build step copied them into the payload, so an installed SAM could not run Both. - installer.yml: "Stage Benchmark producers" publishes both producers self-contained (win-x64) over the SAM assemblies BuildAll already built (BuildProjectReferences=false) and stages their own files beside the app. SAM Analytical is self-contained, so a framework-dependent apphost in its folder finds the app's hostfxr.dll and cannot start. - "Assert Benchmark producers payload": same SAM assemblies and runtime host as the app, self-contained runtimeconfig without probing paths, every deps.json asset present, stamped with this build's InformationalVersion (samCommit then resolves without SAM_COMMIT), and `--help` starts from the payload. The H12 audit also enforces the producers' versions. - Gitlinks: the 23 Q4 tips the S05 acceptance and the S06 dev baseline were built from, and SAM_OpenStudio at the S06 CLI-selection fix (SAM-BIM/SAM_OpenStudio fix/s06-openstudio-cli-sdk-match 1f4bf60c, not yet merged; repoint to its merge commit before this PR merges). Roadmap S06. Candidate build only; no release, tag or publication. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The Clean/Build/Rebuild/Restore targets batched the MSBuild task on
%(Solution.Properties), which groups solutions by that value: every
Release|Any CPU solution, SAM_UI included, was built before SAM_OpenStudio
(the only Release|x64 entry). Since SAM_UI#229 SAM_UI's build requires
SAM_OpenStudio\build\openstudiolib.dll, so moving the SAM_UI gitlink past
#229 failed the Release build ("openstudiolib.dll is missing").
The solutions now go to one MSBuild call in the listed order; each keeps its
Configuration/Platform as Properties metadata and gets the CI properties as
AdditionalProperties. Found by the S06 local installer replay.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… call (S06) ac00b8f passed the CI properties as per-item AdditionalProperties. That is not equivalent: on the same SAM_Revit restore it turns NuGet NU1504 (duplicate System.Text.Json PackageReference, 7 projects) from a warning into an error, which the old Properties= call never did. Keep each MSBuild call exactly as before (same Properties string) and only change Projects="@(Solution)" to Projects="%(Solution.Identity)", so the task batches on (solution, Properties) and runs each entry on its own in the listed order: SAM_OpenStudio (Release|x64) now builds before SAM_UI. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…etadata (S06) 1251d5d (Projects="%(Solution.Identity)") passed bare paths, so the task's Properties parameter applied for the first time - including CommonCIProps' TreatWarningsAsErrors=true - and restore failed on NuGet NU1504 again. Probe: when the Projects items carry Properties metadata, the MSBuild task applies that metadata and ignores its own Properties parameter, so CommonCIProps has never reached the solutions (CI stamping comes from the SAMVersion / InformationalVersion / SAMSourceRevision environment variables). Keep Projects="@(Solution)" exactly as before and add Condition="'%(Solution.Identity)' != ''": each batch is one solution entry, built in the listed order (SAM_OpenStudio before SAM_UI), with the same effective properties as before. Making CommonCIProps effective is out of S06's scope and recorded as a finding. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The Q4 SAM_OCCT panel solver references SAM_Solver\build\SAM.Geometry.Solver* (6 HintPaths), but BuildAll_Release listed SAM_OCCT right after SAM, so the Release rebuild failed with CS0234 'Solver' in SAM.Geometry once the SAM_OCCT gitlink moved to its Q4 tip. Move the entry to just after SAM_Solver; its only other consumer, SAM_Revit_UI, is built later by installer.yml. Checked: every cross-repo ..\SAM*\ reference of every non-test project in the 24 pinned repositories now points to a solution listed earlier. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Record for the content tested at 717533c: BuildAlls_v5 findings, why the installed payload could not run Both, the changes, the local installer replay (20/20 steps, gates PASS, one local-only H12 deviation), and the licensed installed smoke from the real ribbon: Tas, OpenStudio and Both PASS with no SAM_COMMIT, no developer folder, CLI 3.10 chosen over 3.11 first on PATH, the user's %APPDATA%\SAM unchanged. Evidence paths redacted; trailing whitespace stripped from the copied logs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The hosted run #227 installer (717533c) installed and uninstalled in an isolated profile; Tas, OpenStudio and Both PASS from the real ribbon, numerically identical to S05, 3.10 CLI selected with 3.11 first on PATH. Provenance check fails: installed producers report the SAM_Deploy commit as samCommit/runnerCommit (owner decision recorded). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 20, 2026
…rge plan Owner decision 2026-10-20: installed-build samCommit/runnerCommit holding the SAM_Deploy revision is an explicitly documented S06 exception (check 9 stays "not PASS", documented by SAM_Validation#16). Record how to obtain the source revisions from the pinned gitlinks and the approved merge order. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
michaldengusiak
marked this pull request as ready for review
October 20, 2026 09:12
…pping, CI attribution - provenance.application.sourceRevisionOf is explanatory text; the full stamp is in entryAssembly/components informationalVersion (verified against the committed genuine-installer manifests). - 24 gitlinks change: 23 Q4-tip pins + the SAM_OpenStudio content pin. - Raw OpenStudio comparisons stay exactMatch:false; add a check that maps the 4 generated subsurface names uniquely by source reference and finds equal values (new evidence, measured files untouched). - Correct CI attribution (bcc6735 = SAM_Deploy run 39399003022). - Record pre-existing whitespace in verbatim captures. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…rd rules - Subsurface result references are host-panel GUIDs (AddResults.cs LookupPanel/Referenced), not aperture GUIDs. The mapping check now validates actual Panel objects in the source model (one aperture each) and fails on missing or ambiguous mappings; rerun on all four comparisons, which stay exactMatch:false as measured. - Merge plan: repin only SAM_OpenStudio to #32's exact merge commit; carry licensed evidence forward only after source and rebuilt-payload equivalence (dependency/runtime inventory, expected stamp differences); drift repeats the affected genuine-installed cases. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
1f4bf60c -> a9429f7c (merge of #32 into sow/2026-Q4; parents d4216f35 and approved head 3082dc6a). Source diff 1f4bf60c..a9429f7c is only documentation/S06-OpenStudio-Cli-Selection-PR.md. Every other gitlink and .gitmodules unchanged; SAM_Validation stays 68eded00. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ce with #227 SAM_OpenStudio repinned to #32's merge a9429f7c (b3b8e9e): Validate and installer run #228 (publish_release=false) green; 24 checked-out pins, producer Stage/Assert, H12 0 violations, artifact hashes recorded. Genuine isolated installs of #227 and #228 inventoried and compared: 1104 identical, 474+51 stamp-only, 129 .pdb, Inno label; 0 drift, so the licensed x1/x2/x3 evidence carries forward. Merges of #32 and #16 recorded. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Roadmap S06: early SAM_Deploy installed smoke candidate (
SAM/documentation/SIMULATION_ROADMAP_Q4_2026.md).Status: owner approved merging (2026-10-20). #32 and #16 are merged, SAM_OpenStudio is repinned to #32's merge commit, the repin gates passed, and payload equivalence PASS. Every check passes except check 9 (provenance). On 2026-10-20 the owner accepted check 9 as an explicitly documented S06 limitation; it is recorded as that, not as PASS. SAM-BIM/SAM_Validation#16 documents it. Candidate build only: no release, tag or publication. Do not merge without explicit owner approval.
Record:
DEPLOY_S06_SMOKE_CANDIDATE.md. Evidence:evidence/s06-20261020/. Supporting PR: SAM-BIM/SAM_OpenStudio#32.Change
win-x64) and staged besideSAM Analytical.exe. A new gate,.github/scripts/benchmark-producers-payload.ps1, checks their dependencies, runtime, identical SAM assemblies and stamp, and that they start from the payload.BuildAll_Releasebuild order.sow/2026-Q4tips, and the supporting SAM_OpenStudio content pin points at chore: bump submodule pointers (SAM_Windows, SAM_Revit_UI, SAM_Tas_Grasshopper) #32's1f4bf60c..gitmodulesis unchanged.Commits
717533c1faa3832665546bcc67350aac7aa47d7adf1f4bf60c->a9429f7c(#32's merge)b3b8e9ef14f71eAcceptance (2026-10-20)
publish_release=false) at717533c; local replay 20/20 steps2026.4.227.0+717533cd4216f35+ #32Documents\SAMfolders were unchanged: 2518 entries, 0 differencesSucceededSucceeded, EnergyPlus exit 0Compared, both producers exit 0. The harness needed one re-click of the weather dialog; this is recorded and does not affect the appSAM_COMMIT/SAM_BENCHMARK_*. The app and both producers ran from the install folder, the .NET root was the install folder, and there were 0 developer-folder referencesPATH→ 3.10 CLIexactMatch: false(45/45 numbers, 24 differences), kept as measured. All 24 differences are 4 run-generated subsurface names. Through the result reference, which is the host-panel GUID (AddResults.cs), each maps 1:1 to one name on the other side. Each of the 4 panels is aPanelobject of the input model with exactly one aperture. The check fails on missing or ambiguous mappings, and the claim is scoped to these comparisons, with exactly equal values (runs/os-subsurface-mapping.txt); Both snapshot, EPW5afbeb32, canonical hash andcomparison.csv454e42dcequal717533c✅ and1faa383✅;2665546✅ (run 39396367650);bcc6735✅ (SAM_Deploy run 39399003022). An earlier version of this description gave run 39398892361 here, which is SAM_Validation#16's run.0aac7aa✅ (run 39403322329); current head47d7adf✅ (SAM_Deploy run 39407467996). SAM_OpenStudio#32: 51/51 tests passed again locally; hosted build and spdx ✅Environment: licensed laptop, TAS 9.5.7.0, OpenStudio 3.10.0 CLI (portable copy) with ladybug 3.11.0 first on
PATH, EnergyPlus 25.1.0, Windows 11.Check 9: accepted, documented limitation
In an installed build, both producers report
samCommit=runnerCommit=717533c, the SAM_Deploy build revision.comparison.mdprints it as "SAM commit". SAM_UI's own run manifest is correct. Underprovenance.application,sourceRevision=717533c(the extracted SHA), andentryAssembly.informationalVersion/components[].informationalVersion=2026.4.227.0+717533c(the full stamp).sourceRevisionOfis explanatory text.The owner decided on 2026-10-20 to accept this as an explicitly documented S06 exception, with no new stamping. SAM-BIM/SAM_Validation#16 documents it in
SCHEMA.md:git ls-tree 717533c SAM SAM_Tas SAM_OpenStudiogives SAMdf27563b, SAM_Tase84aeff6and SAM_OpenStudio1f4bf60c.Hosted vs local
Machine-local inputs are not committed: the TAS licence, the 3.10 runtime, the S05 inputs, and
C:\TasOut\s06.Repin and payload equivalence (done 2026-10-20)
Merged S06: prefer the OpenStudio CLI that matches the SDK SAM_OpenStudio#32 as
a9429f7c(approved head3082dc6; post-merge Build 39409026705 ✅; closeout7f21665).Merged docs: installed-build samCommit/runnerCommit hold the SAM_Deploy revision (S06) SAM_Validation#16 as
e9a83df0(approved headed7a878; post-merge Build 39409164929 ✅; closeout2a3acfa).b3b8e9erepins only SAM_OpenStudio:1f4bf60c→a9429f7c, the exact merge commit and not the closeout tip. The diff1f4bf60c..a9429f7cis chore: bump submodule pointers (SAM_Windows, SAM_Revit_UI, SAM_Tas_Grasshopper) #32's record document only. The other 23 pins and.gitmodulesare unchanged, and SAM_Validation stays68eded00.At
b3b8e9e:publish_release=false, release job skipped): stamp2026.4.228.0+b3b8e9e, the 24 checked-out pins equal the gitlinks, producer Stage/Assert pass with both producers starting, and H12 has 0 violations;a9284962…f58c9.Payload equivalence (local; the #227 and #228 EXEs genuinely installed into isolated profiles, inventoried and uninstalled; owner folders unchanged), over 1759 paths:
runtimeconfig.jsonfiles and OpenStudio/EnergyPlus nativesdeps.jsonfiles identical after normalising the stamp and SAM_OCCT's1.0.*build-time version.pdbdebug symbols, reported separatelyThe licensed x1/x2/x3 evidence carries forward. Evidence is in
evidence/s06-20261020/repin/.Remaining
🤖 Generated with Claude Code