Repository navigation
[Fix] Sessions cannot be selected or deleted in bulk from the list or board - #3626
Merged
Merged
Conversation
Contributor
|
No code issues found. See session Reviewed selection and permission scoping, list/board interactions, deletion confirmation and partial-failure retry, refresh/reset behavior, and the tests and documentation. CI lint, type checks, Knip, and docs validation passed; tests, app build, and JavaScript/TypeScript CodeQL were still running. Repository validation suites were left to CI. Reviewed 4483ee1 |
brunobergher
marked this pull request as ready for review
October 29, 2026 17:36
brunobergher
requested review from
brunobergher,
daniel-lxs and
mrubens
as code owners
October 29, 2026 17:36
brunobergher
approved these changes
Oct 29, 2026
Merged
8 of 12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Requested maintenance; no linked issue.
Why this PR exists
What changed
Why this change was made
The historical Tasks overview had selection mode, individual checkboxes, select-all for loaded results, and confirmed bulk deletion. When #1708 made Sessions the primary workspace, navigation moved from
/tasksto a Sessions page without those controls. Source history does not show prior Shift-range selection, and the old Tasks board explicitly hid its selection toggle. This restores the evidenced interaction pattern and makes it consistent in both current views, without inventing range-selection semantics. The later board removal/return (#2946, #3212, #3296) did not restore selection.The overview redirect came from the unconditional
router.push('/')introduced for workspace deletion in #2912, then reused for list rows in #3042.Impact
Users can select and delete several sessions from either overview and remain in that overview. All is page-scoped and respects the existing management permissions; there is no cross-page hidden selection. Authorization, active-work stopping, artifact cleanup, and memory cleanup continue through the existing server command.
How it was tested
pnpm exec dotenvx run -f .env.test -- pnpm --filter @roomote/web exec vitest run --project client 'src/app/(authenticated)/sessions/' 'src/app/(sandbox)/sessions/[sessionId]/SessionDeleteAction.client.test.tsx'— 77 tests passed in 6 files. Includes both views, selection vs links/drag activators, select-all and management limits, confirmation/cancel, one/multiple deletions, pending controls, partial failures/retry, empty-result pruning, and view/filter/page resets.check-types:fast, focused ESLint, andgit diff --checkpassed. The push hook also passed monorepo oxlint, residual ESLint, fast typechecks, and knip.mise exec -- pnpm --filter @roomote/docs checkpassed build validation and broken-link checks. The rendered docs preview could not be verified: the existing local Mintlify preview displayed a blank page and loggedError: No docs config.Checklist
[Fix],[Feat],[Improve],[Refactor],[Docs], or[Chore]followed by a user-facing descriptionpnpm lintandpnpm check-typespass locally — ran the repository's normal fast pre-push equivalents insteadpnpm changeset— not runScreenshots
Genuine sandbox app with seeded demo records and development authentication. The list shows two selected and two unselected rows with Delete (2); the board shows All selecting four sessions across two lanes. Post-deletion frames show the retained overview/filter and success toasts. These still images support the visible states; interaction and navigation assertions come from the browser checks above.