Skip to content

[Fix] Sessions cannot be selected or deleted in bulk from the list or board - #3626

Merged
brunobergher merged 1 commit into
developfrom
fix/session-multiselect-0yxbjfv3kct1z
Oct 29, 2026
Merged

brunobergher merged 1 commit into
developfrom
fix/session-multiselect-0yxbjfv3kct1z

Conversation

@roomote-roomote

Copy link
Copy Markdown
Contributor

​Created by Roomote. Follow up by mentioning @roomote-roomote, in the web UI, or in Slack.

Related issue

Requested maintenance; no linked issue.

Why this PR exists

  • A maintainer explicitly invited this PR in the linked issue or discussion
  • I am a maintainer / this is internal Roomote work

What changed

  • Restore an explicit Select sessions mode in both the Sessions list and board. Check individual sessions or use All for manageable sessions on the current page, then confirm Delete (n). Normal session links return when selection mode exits; board dragging is disabled while selecting. Existing row actions and artifact/PR links remain available.
  • Keep single and bulk overview deletion on the current list/board, with its filters and pagination. The single-row action now closes its dialog and refreshes instead of redirecting home; workspace deletion retains its existing navigation.
  • Prune removed or no-longer-manageable selections on refresh and clear selection when views, filters, or pages change. Bulk deletion reuses the existing per-session deletion mutation and safeguards, retains failures for retry, and exits selection mode after complete success.
  • Document the selection and deletion workflow.

Why this change was made

The historical Tasks overview had selection mode, individual checkboxes, select-all for loaded results, and confirmed bulk deletion. When #1708 made Sessions the primary workspace, navigation moved from /tasks to a Sessions page without those controls. Source history does not show prior Shift-range selection, and the old Tasks board explicitly hid its selection toggle. This restores the evidenced interaction pattern and makes it consistent in both current views, without inventing range-selection semantics. The later board removal/return (#2946, #3212, #3296) did not restore selection.

The overview redirect came from the unconditional router.push('/') introduced for workspace deletion in #2912, then reused for list rows in #3042.

Impact

Users can select and delete several sessions from either overview and remain in that overview. All is page-scoped and respects the existing management permissions; there is no cross-page hidden selection. Authorization, active-work stopping, artifact cleanup, and memory cleanup continue through the existing server command.

How it was tested

  • pnpm exec dotenvx run -f .env.test -- pnpm --filter @roomote/web exec vitest run --project client 'src/app/(authenticated)/sessions/' 'src/app/(sandbox)/sessions/[sessionId]/SessionDeleteAction.client.test.tsx' — 77 tests passed in 6 files. Includes both views, selection vs links/drag activators, select-all and management limits, confirmation/cancel, one/multiple deletions, pending controls, partial failures/retry, empty-result pruning, and view/filter/page resets.
  • Web check-types:fast, focused ESLint, and git diff --check passed. The push hook also passed monorepo oxlint, residual ESLint, fast typechecks, and knip.
  • Real authenticated browser interactions against the sandbox app and seeded database: individual/card selection, select-all across board lanes, normal session navigation, view-switch selection reset, and successful single/bulk deletion in both views without a homepage redirect. The final screenshots show the Last 30 Days filter retained after deletion. Browser checks used genuine local mutations; no DOM/network mocks.
  • mise exec -- pnpm --filter @roomote/docs check passed build validation and broken-link checks. The rendered docs preview could not be verified: the existing local Mintlify preview displayed a blank page and logged Error: No docs config.
  • Desktop screenshots were opened and visually reviewed. Mobile/dark-theme browser proof and real-browser partial-failure paths were not captured; partial failures are covered by client regression tests.

Checklist

  • The PR title follows the repo convention: [Fix], [Feat], [Improve], [Refactor], [Docs], or [Chore] followed by a user-facing description
  • This PR is small and scoped to one change
  • pnpm lint and pnpm check-types pass locally — ran the repository's normal fast pre-push equivalents instead
  • I added tests or included a clear manual validation note above
  • I removed secrets, tokens, private keys, and customer data from code, logs, and screenshots
  • If this change should appear in the changelog, I ran pnpm changeset — not run

Screenshots

Genuine sandbox app with seeded demo records and development authentication. The list shows two selected and two unselected rows with Delete (2); the board shows All selecting four sessions across two lanes. Post-deletion frames show the retained overview/filter and success toasts. These still images support the visible states; interaction and navigation assertions come from the browser checks above.

List with two selected rows and Delete (2)

Board with four selected cards across Active and Ready

Board retained after deleting two sessions, with Last 30 Days unchanged

List retained after deleting one session, with Last 30 Days unchanged

@roomote-community

roomote-community Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

No code issues found. See session

Reviewed selection and permission scoping, list/board interactions, deletion confirmation and partial-failure retry, refresh/reset behavior, and the tests and documentation. CI lint, type checks, Knip, and docs validation passed; tests, app build, and JavaScript/TypeScript CodeQL were still running. Repository validation suites were left to CI.

Reviewed 4483ee1

@brunobergher
brunobergher marked this pull request as ready for review October 29, 2026 17:36
@brunobergher
brunobergher merged commit c97173a into develop Oct 29, 2026
27 checks passed
@brunobergher
brunobergher deleted the fix/session-multiselect-0yxbjfv3kct1z branch October 29, 2026 17:54
@roomote-roomote roomote-roomote Bot mentioned this pull request Oct 31, 2026
8 of 12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants