Repository navigation
[Chore] Patch @hono/node-server static-file path checks - #3625
Open
roomote-roomote[bot] wants to merge 1 commit into
Open
roomote-roomote[bot] wants to merge 1 commit into
roomote-roomote[bot] wants to merge 1 commit into
Conversation
Contributor
|
No code issues found. See session Reviewed all five changed files, direct and transitive dependency alignment, registry integrity and Node/Hono compatibility, and API, BullMQ static-file, and worker adapter usage. No concrete regression identified. CI: completed checks are passing, including lint, Knip and CodeQL. Tests, typechecking, Docker builds and upgrade compatibility are still running. Repository validation suites were left to CI. Reviewed 625b408 |
roomote-roomote
Bot
requested review from
brunobergher,
daniel-lxs and
mrubens
as code owners
October 29, 2026 16:34
5 of 8 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Security maintenance for GHSA-rmxm-3fg6-px4f (medium, CVSS 5.3). No linked repository issue.
Why this PR exists
What changed
Bump the three direct
@hono/node-serverpins and existing workspace-wide override from2.0.10to2.1.3. Update the lockfile resolution, integrity and MCP SDK transitive reference. No unrelated package upgrades or package-manager policy changes.The advisory identifies
>=1.19.10 <2.1.3as affected and2.1.3as the first patched release for inconsistent static-path decoding. Upstream release notes confirm the fix. Official package metadata requires Node >=20 and Hono ^4, compatible with the repository's Node ranges and unchanged Hono 4.13.11. The September 29 release satisfies the existing seven-day minimum release age without an exception.No intended change to ordinary serving. Upstream now rejects remaining percent signs in decoded static paths by default; applications intentionally serving literal-percent filenames require upstream's
allowPercentInPathoption. No application settings were changed.How it was tested
On Node 24.22.1 and pnpm 10.29.3:
pnpm -r why @hono/node-serverconfirms direct and transitive resolution to 2.1.3.serveandcreateAdaptorServer: JSON health, static text GET, ordinary encoded-space filenames, HEAD and missing-file 404. This is an isolated normal-serving check, not full application end-to-end coverage.git diff --checkpass.Validation log: commands, exit codes and output. Normal-serving smoke source.
Checklist
[Fix],[Feat],[Improve],[Refactor],[Docs], or[Chore]followed by a user-facing descriptionpnpm lintandpnpm check-typespass locallylint:fast-equivalent pre-push gates andcheck-types:fastsuccessfully; formatting-inclusive full commands were not run.pnpm changeset