Repository navigation
[Chore] Patch body-parser runtime denial of service - #3628
Open
roomote-roomote[bot] wants to merge 1 commit into
Open
roomote-roomote[bot] wants to merge 1 commit into
roomote-roomote[bot] wants to merge 1 commit into
Conversation
Contributor
|
No code issues found. See session Reviewed the override, all lockfile changes, MCP SDK → Express dependency resolution, upstream parser requirements and security fix, and unchanged release-age policy. Both relinked Vitest peer contexts exist. The deferred authentication alerts are outside this parser-only diff. Current-head CI lint, typecheck, Knip, upgrade compatibility, and CodeQL checks passed; tests and the app image build were still running when checked. Repository validation suites were not rerun during review. Reviewed 5ec9b4b |
roomote-roomote
Bot
requested review from
brunobergher,
daniel-lxs and
mrubens
as code owners
October 30, 2026 03:30
5 of 8 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Addresses Dependabot alert #301, the high-severity body-parser compressed-body denial of service (GHSA-27r3-jxmh-p828). Partial result: the six requested authentication alerts #310–#315 remain unresolved, as explained below. No alerts were dismissed; GitHub closure of #301 awaits merge and dependency rescan.
Why this PR exists
Apply the independently safe parser security patch without introducing the confirmed sign-in regressions encountered in the authentication upgrade. Live alerts and open PR coverage were rechecked; existing dependency PRs #3600 and #3625 do not remediate this parser alert.
What changed
minimumReleaseAge: 10080and all exclusions byte-for-byte. All three new resolutions exceed seven days; body-parser 2.4.0 was published October 22, 2026 at 11:39:38 UTC and became eligible October 29. Release notes confirm the security fix, parser-option handling changes, and added Zstandard support.There is no intended user-visible behavior change from the delivered parser update.
Authentication bundle deferred: compatibility migration required
An aligned Better Auth/core/adapter 1.7.12 attempt passed the existing web server tests but failed web typechecking:
genericOAuthClientis removed, and Slack's callback-valuedauthorizationUrlParamsis unsupported. Upstream 1.7.7 and 1.7.12 use social sign-in/linking endpoints and/callback/:id, while Roomote's client and registered provider redirects use the old OAuth2 endpoints. The Microsoft helper also changes existing linked-account identity fromsubtooidand rejects formerly supported non-GUID tenants. An import-only repair would leave real authentication broken.The attempted authentication edits were fully reverted. Critical alert #311, high alerts #310/#312, and low alerts #313/#314/#315 remain open and uncovered. They need a behavior-preserving OAuth/client/callback/account-identity migration with real upgraded-library regression coverage. Release age is not blocking authentication. Compatibility assessment and next remediation.
How it was tested
Final parser-only graph, Node 24.22.1 / pnpm 10.29.3:
Checklist
[Fix],[Feat],[Improve],[Refactor],[Docs], or[Chore]followed by a user-facing descriptionpnpm lintandpnpm check-typespass locallypnpm changeset