Repository navigation
[Docs] Repair provider icons and stale setup guidance - #3594
Draft
roomote-community[bot] wants to merge 1 commit into
Draft
roomote-community[bot] wants to merge 1 commit into
roomote-community[bot] wants to merge 1 commit into
Conversation
Contributor
Author
|
1 issue outstanding. See session
Reviewed 9f7c10a |
| (icon?.startsWith('/') | ||
| ? icon | ||
| : `https://api.iconify.design/simple-icons:${icon}.svg?color=currentColor`); | ||
| : `https://api.iconify.design/simple-icons/${icon}.svg?color=currentColor`); |
Contributor
Author
There was a problem hiding this comment.
[P2] Update the dark-mode CSS selectors alongside the Iconify URLs. apps/docs/roomote.css:124 still applies filter: invert(1) only to URLs starting with https://api.iconify.design/simple-icons:. The new slash-based URLs no longer match, and currentColor inside an external SVG image defaults to black rather than inheriting the page text color. In the Mintlify preview, switching /integrations to Dark leaves the repaired table and sidebar logos black against the dark background (computed filter: none). Update the Iconify selectors in roomote.css to match the repaired URL prefix so both inline and frontmatter logos remain legible.
Merged
7 of 11 tasks
This was referenced Oct 27, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Scheduled comprehensive public-documentation audit; no linked issue.
Why this PR exists
What changed
Why this change was made
The audit read all 123 public MDX pages, including hidden installation guidance and every Cookbook recipe, against integration
e12f1701and shipped main/v1.19.3b532d7eb. Their product/docs trees are identical; only CHANGELOG.md differs. The page-by-page coverage and claim-evidence report retains baseline hashes, source references, external evidence, pending findings, and verification limits.Revalidated prior audit PRs #3468 and #3515: both remain open and unmerged. Their pending corrections and the optional-chat, source-control prerequisite, and historical ChatGPT redirect fixes in #3514, #3593, and #3466 are not duplicated. The old unreleased HAR/rotation caveats in #3515/#3548 no longer match the shipped baseline.
Impact
Documentation-only corrections across 39 files, mostly one-line icon URL repairs. Readers get working provider logos and setup/resource guidance aligned with current implementation. This is not a clean-corpus certification: known corrections remain pending in the PRs above, and exhaustive reading does not mean every vendor/account/UI claim was independently exercised end to end.
How it was tested
mise exec -- pnpm --filter @roomote/docs checkpassed on the baseline and final diff: repository-pinned Mintlify 4.2.650 validation followed by internal broken-link checking.mise exec -- pnpm --filter @roomote/docs check-cookbook-indexpassed with seven recipes; no generated drift.git diff --checkand normal commit/push hooks passed: oxfmt, oxlint, web/worker residual ESLint, all 27 typecheck tasks, and Knip. Full Vitest and formatting-inclusivepnpm lint/pnpm check-typeswere not run for this docs-only diff.Checklist
[Fix],[Feat],[Improve],[Refactor],[Docs], or[Chore]followed by a user-facing descriptionpnpm lintandpnpm check-typespass locallypnpm changesetNo changeset is needed for documentation-only corrections.
Screenshots
Genuine local Mintlify rendering, without mocks or simulated state. These demonstrate representative documentation appearance, not integration authorization or resource-limit enforcement. Other edited paragraphs, lower table rows, mobile layouts, and dark theme are not pictured.
Shows six integration-table logos and matching Asana, Better Stack, and Buildkite sidebar logos.
Shows the 2048-PID runtime default, supplied Compose 512-PID default, operator override, and repaired Docker sidebar icon.