Repository navigation
Release Roomote 1.19.4 - #3597
Conversation
|
No outstanding code issues found. See session Reviewed the CSS update since the previous review against the shared icon helper and affected provider frontmatter. Both silhouette and dark-theme selectors now match slash-format Iconify URLs while retaining legacy colon support. The prior finding is fixed and its thread is resolved. This pass verified the fix from source; browser rendering was not rerun. Current-head docs validation, tests, lint, type checks, and Knip passed. The application Docker build and JavaScript/TypeScript CodeQL analysis were still running when checked.
Reviewed 0384c61 |
|
Fixed in 0384c619: both docs CSS rules recognize slash-format Iconify URLs while retaining colon-format support. Genuine browser checks verified all nine loaded slash icons invert in dark theme, stay uninverted in light theme, and keep unrounded silhouettes; existing colon selectors still apply. Light/dark screenshots are embedded in the PR. Push gates and GitHub Docs validation passed. Automatic Roomote code review passed with no outstanding issues; Judgement passed. The fixed thread is resolved. PR #3597 was subsequently observed merged externally; this fixer did not merge or promote it. The application Docker build was still running at the last check. |
Related issue
Maintainer-requested normal release preparation; no linked issue.
Why this PR exists
What changed
Prepare Roomote 1.19.3 → 1.19.4 using the maintainer-selected patch bump. Generated the root version and changelog through
pnpm run version, consumed both patch inputs, and polished the in-app summary and highlights. Workspace package versions remain unchanged.The complete audited scope is GPT-6.1 Terra support #3595 and Kimi K3.1 Pro/Highspeed support #3596, through develop
62112eb0f8c4c3a2b49891e509891567504c99ee. Publishedv1.19.3matches main atb532d7eb7e8cc672c7e0ea7527f8de67809462d6. No open preparation/Promote duplicate or unshipped version candidate was found. Both source PRs are App-authored and close no issues; no eligible external acknowledgements are missing.Patch changes
Public documentation coverage
The review correction updates both CSS rules to recognize Iconify's slash URLs alongside legacy colon URLs, preserving dark-theme contrast and unrounded silhouettes in table and sidebar marks.
Inspected open docs audit PR #3594. This release includes its needed one-line shared Iconify URL correction and matching OpenCode/Vercel frontmatter fixes; its broader setup and site-wide icon audit is not copied. Its shared-snippet overlap must be reconciled when it lands. Unrelated provider-icon gaps remain outside this release's affected provider scope.
Squash-merging this PR cuts the release and automatically opens the frozen Promote v1.19.4 to production PR against
main. Preparation CI/reviews do not validate the later promotion head.How it was tested
pnpm run versiongenerated 1.19.4 and consumed two patch notes, including the existing Kimi note and the locally authored Terra note.git diff --checkpassed.filter: nonein dark theme and sidebar icons had12pxrounding. After the fix, all nine useinvert(1)and0pxradius in dark theme, andnone/0pxin light theme. Selected both themes through the actual UI; no mocked state or DOM content edits.0384c619, GitHub Docs validation, lint, type checks, Knip, deployment-artifact checks, and Judgement evidence/result jobs passed at observation. Roomote re-review and remaining CI jobs were still running. CI and Docs must succeed on this PR before merge.Checklist
[Fix],[Feat],[Improve],[Refactor],[Docs], or[Chore]followed by a user-facing descriptionRelease Roomote X.Y.Ztitle convention.pnpm lintandpnpm check-typespass locallypnpm changesetScreenshots
Genuine local Mintlify rendering, no mocks or content changes. Shows desktop light/dark appearance and matching affected provider sidebar marks. Existing unrelated GitHub Copilot sidebar-icon gap is outside this release's scope.