Skip to content

fix(ros2): reject non-positive waiters time_interval #855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Bartok9 wants to merge 1 commit into from
Closed

fix(ros2): reject non-positive waiters time_interval #855

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/rai_core/rai/communication/ros2/waiters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,8 @@ def wait_for_ros2_entities(

if timeout < 0:
raise ValueError("Timeout must be 0 (wait forever) or a positive value.")
if time_interval <= 0:
raise ValueError("time_interval must be positive.")
start_time = time.time()

while timeout == 0 or time.time() - start_time < timeout:
Expand Down
14 changes: 14 additions & 0 deletions tests/communication/ros2/test_waiters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,3 +168,17 @@ def test_wait_for_ros2_entities_negative_timeout():
get_entities=lambda: [],
timeout=-1,
)


def test_wait_for_entities_rejects_non_positive_time_interval():
import pytest
from rai.communication.ros2 import waiters

with pytest.raises(ValueError, match="time_interval"):
waiters.wait_for_ros2_entities(
["/x"], lambda: [], time_interval=0, timeout=1.0
)
with pytest.raises(ValueError, match="time_interval"):
waiters.wait_for_ros2_entities(
["/x"], lambda: [], time_interval=-0.5, timeout=1.0
)