Repository navigation
Conversation
Prevent busy-spin when time_interval is 0 and reject negative poll gaps.
Bartok9
force-pushed
the
aerial/waiters-time-interval-positive
branch
from
August 12, 2026 17:25
4966aa5 to
aff2f6d
Compare
Member
|
Going to pass on this one. Our own waiter tests call wait_for_ros2_topics with time_interval=0 and time.sleep patched out, which is a reasonable way to run them, so the guard would break them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Poll interval must be > 0. Timeout may still be 0 for wait-forever.
pytest tests/communication/ros2/test_waiters.pyClaim: bartok
Operator: bartok
Campaign: aerial-drone