Preserve Roam's React 18 hook and release 0.90.0 - #67
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex review |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review Round 2: focus on the published package, shared build mapping, and compatibility with existing extensions. Please report actionable regressions. |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review Round 3 (final): review regression coverage and release safety, including whether the removed global writes remain anywhere in the package. Please report actionable issues. |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Roam now provides React 18.2.0 and its native useSyncExternalStore hook. Extension startup currently assigns a compatibility hook onto shared window.React; the package build mapping also performs that assignment. This can interfere with components already using the shared hook.
Remove both assignments and use the host React export. Bump the minor version to 0.90.0 and document that consumers need a host providing this hook. Existing extension bundles need rebuilding; custom build configurations must remove their own shim injection separately.
Validation: package build, full ESLint (one existing warning), and two regression tests passed. The tests initialize/unload multiple extensions against frozen React exports and execute the configured React mapping. Unit tests also run in PR CI.
Related: DiscourseGraphs/discourse-graph#1369. DG currently carries the equivalent loader patch and passed manual direct cloud loads with Breadcrumbs and SmartBlocks enabled. After this release is published, DG can replace that patch with the released dependency.
Release: merging this version change to main triggers the existing npm publish workflow. Awaiting maintainer review before merge.