ENG-2211 Fix Roam direct canvas load race - #1369
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex review |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Direct cloud canvas loads can crash when another extension changes the shared React hook during startup. DG now captures Roam's React exports once, keeping the initial useSyncExternalStore implementation stable across renders. Roam provides React 18.2.0, so DG no longer injects a React 17 fallback.
Limitation: if another extension replaces the hook before DG initializes, DG captures that implementation. This change prevents later replacements; it does not recover an overwritten native hook.
Validation: pnpm install --frozen-lockfile, pnpm ci:validate (including 112 Roam tests), and the production build passed with published roamjs-components 0.90.0. Live verification on daeb12c passed with Breadcrumbs and SmartBlocks enabled: two direct cloud-canvas reloads, a direct local-canvas reload, and daily-note navigation into the cloud canvas. No console warnings or errors were recorded, and DG settings confirmed the loaded commit. Extension settings were preserved. GitHub format, lint, validate, and deployment checks passed.
Upstream: RoamJS/roamjs-components#67 (merged and published).