Repository navigation
Scaffold Electron app and add single-device SSH connect (Phases 0–1) - #1
Merged
Merged
Conversation
- Electron + React + TypeScript app built with electron-vite - Secure window: context isolation, sandbox, no Node in renderer, CSP - Preload bridge exposed as window.bulkssh (app version over IPC) - Placeholder layout: device list, grid area, broadcast bar - Shared paging helpers (default 6 devices per page) with Vitest tests - electron-builder config for Windows NSIS installer and portable exe - .gitignore keeps device lists, settings and SSH keys out of git - Project plan in .projectPlan/PLAN.md, CLAUDE.md, project skills
- .claude/launch.json: single "dev" config running npm run dev on port 5173 - Pin the electron-vite renderer dev server to 5173 with strictPort - Make window.bulkssh optional so the renderer loads in a plain browser - Document the preview setup in CLAUDE.md
- Transport interface with an ssh2-based SshTransport (password, keyboard-interactive and private key auth, encrypted key passphrases) - Session manager: one session per device, readable connection errors, re-prompts on wrong password or passphrase - Host key trust-on-first-use: native dialog for unknown and changed keys, trusted keys stored in known_hosts.json - Device store (devices.json in userData) with shared validation; secrets are never written to disk - IPC handlers validate every argument and reject unknown senders - Renderer: device list, add/edit form, password prompt, xterm.js terminal with fit-to-size and resize forwarding - npm run dev:ssh: local SSH server with a fake shell for manual testing - Tests: device validation, stores, and session manager against an in-process ssh2 server (34 tests) - Update CLAUDE.md and the project plan
Runs npm ci --ignore-scripts, typecheck and Vitest on windows-latest (Node 24) for pull requests and pushes to main.
This was referenced Oct 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The first two phases of the project plan:
Phase 0: scaffold
electron-vite; Vitest for tests; electron-builder for a Windows installer and portable exe.claude/launch.jsonwith a singledevpreview config (the old file came from an unrelated project and held plaintext passwords; it was never committed)CLAUDE.mdand the project planPhase 1: single-device SSH connect
Transportinterface plusSshTransport(ssh2), so telnet, serial and SFTP can be added later without touching the UIknown_hosts.json.npm run dev:ssh: a local SSH server with a fake shell for manual testing (no Docker or sshd needed)Why
This sets up the base that the later phases build on: multi-device grid and paging, mirrored keystrokes, focus mode.
For reviewers
devices.jsonstores only host, port, username and the key's file path.src/main/ipc.tsvalidates every argument and rejects messages from any sender other than the app window.ssh2'sgenerateKeyPairSync('ed25519')produces a malformed key about 1 time in 200; OpenSSH'sssh-keygenrejects these keys too. The test helper and the dev server retry key generation. Keys made withssh-keygenare unaffected.npm installreports 8 moderate-severity advisories in dev dependencies; I haven't looked into them yet.Testing
npm run typecheckis clean.npm test: 34 tests, including the session manager against an in-process ssh2 server (password, keyboard-interactive, unencrypted and encrypted keys, wrong secrets, unknown/changed/rejected host keys, refused connections, resize). 30 consecutive runs passed after the key-generation fix.npm run dev:ssh, driven over the DevTools protocol: form validation, save, wrong password re-prompt, connect, typed commands, terminal resize (server saw 43 → 17 rows), and disconnect.npm run dist.🤖 Generated with Claude Code