Repository navigation
Keystroke mirroring and command broadcast (Phase 3) - #3
Merged
Merged
Conversation
- Electron + React + TypeScript app built with electron-vite - Secure window: context isolation, sandbox, no Node in renderer, CSP - Preload bridge exposed as window.bulkssh (app version over IPC) - Placeholder layout: device list, grid area, broadcast bar - Shared paging helpers (default 6 devices per page) with Vitest tests - electron-builder config for Windows NSIS installer and portable exe - .gitignore keeps device lists, settings and SSH keys out of git - Project plan in .projectPlan/PLAN.md, CLAUDE.md, project skills
- .claude/launch.json: single "dev" config running npm run dev on port 5173 - Pin the electron-vite renderer dev server to 5173 with strictPort - Make window.bulkssh optional so the renderer loads in a plain browser - Document the preview setup in CLAUDE.md
- Transport interface with an ssh2-based SshTransport (password, keyboard-interactive and private key auth, encrypted key passphrases) - Session manager: one session per device, readable connection errors, re-prompts on wrong password or passphrase - Host key trust-on-first-use: native dialog for unknown and changed keys, trusted keys stored in known_hosts.json - Device store (devices.json in userData) with shared validation; secrets are never written to disk - IPC handlers validate every argument and reject unknown senders - Renderer: device list, add/edit form, password prompt, xterm.js terminal with fit-to-size and resize forwarding - npm run dev:ssh: local SSH server with a fake shell for manual testing - Tests: device validation, stores, and session manager against an in-process ssh2 server (34 tests) - Update CLAUDE.md and the project plan
Runs npm ci --ignore-scripts, typecheck and Vitest on windows-latest (Node 24) for pull requests and pushes to main.
- Paged grid of live terminal tiles for open devices, ordered by device number; tiles stay after a disconnect until closed - Grid shape from min(page size, open devices) so every page has the same tile size and page switches never resize terminals - Pager with numbered pages, Ctrl+PageUp/PageDown (kept from reaching the device), and clicking a device row jumps to its tile - Connect all / Disconnect all; password prompts are queued, with an option to reuse one password for the other waiting devices - Settings dialog and settings.json for devices per page (1-36, default 6) - Host-key dialogs queued in the main process so bulk connects never stack them - Tests for grid shape, page clamping and settings (48 total) - Update CLAUDE.md and the project plan
- "Send to" checkbox per device with All / None / Invert - Mirror mode (button or Ctrl+Shift+M): input typed into a tile also goes to every other checked, connected device via one writeMany IPC call; source and mirrored tiles are badged and outlined - Terminal replies (cursor/attribute reports, focus and mouse events, OSC/DCS replies) are never mirrored - Broadcast runs a command on checked devices over SSH exec channels in parallel, with per-device output, exit code and duration; output capped at 64 KB; per-device timeout setting (default 30 s) - One failing, slow or disconnected device never affects the others - Dev SSH server: exec support plus sleep, fail and fail-on commands - Tests for mirror targets, the report filter, writeMany and exec (84 total) - Update CLAUDE.md and the project plan
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Phase 3 of the project plan: sending input to many devices.
writeManyIPC call per keystroke. Tiles are badged source / mirrored.isTerminalReportkeeps them away from the other devices.sleep,failandfail-on <n>commands.For reviewers
SessionManager.execnever throws; every failure becomes an{ ok: false }row, so one device can't break a broadcast.Testing
npm test: 84 tests, adding mirror targets, the report filter (with false-positive cases),writeMany, exit codes and stderr, truncation, and one device timing out while the others succeed.fail-on 3failed only on device 3. A disconnected device dropped out of the target count. With a 2 s timeout,sleep 5stopped on every device while the shells stayed usable.🤖 Generated with Claude Code