Adding support for Biotek Multiflo, MultiFloFX and 405TS; Improving support of EL406 - #1266
Open
stefanmaak wants to merge 20 commits into
Open
stefanmaak wants to merge 20 commits into
stefanmaak wants to merge 20 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support of the biotek washer/dispenser family members MultiFlo, MultiFloFX, 405TS and EL406.
The support features:
Breaking:
pylabrobot.agilent.biotek.el406is removed.EL406now lives atpylabrobot.agilent.biotek.lhc.EL406, and its operations take step objects instead of longflat keyword lists (
wash(): 39 keyword arguments to nine). The unrelated legacy backend inpylabrobot/legacy/plate_washing/biotek/el406/is untouched.The implementation comes from decompiling and translating the agilents LHC2 software and has been tested against it afterwards leading to high confidence in being correct. The Software has been also tested with real MultiFloFX and Washer 405TS. All "reference captures from real EL406 hardware"-tests from the removed el406 implementation are reproduced.
A few bugs (with carrier homing, some validation ranges and serialization of positioning in final_aspirate) of the original el406 implementation are fixed.
Updated CHANGELOG and CODEOWNERS.
The code was almost fully written by claude with me only making the package structure and some design choices.
This PR text is written by me ;-)