Repository navigation
Simplify Contact copy and use supplied adaptive favicon #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| { | ||
| "name": "OpenDQM", | ||
| "short_name": "OpenDQM", | ||
| "icons": [ | ||
| { | ||
| "src": "web-app-manifest-192x192.png", | ||
| "sizes": "192x192", | ||
| "type": "image/png", | ||
| "purpose": "maskable" | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
On platforms that apply a mask to installed-app icons, both supplied images can be visibly cropped because their foreground extends nearly edge-to-edge (x=2–187 in the 192px image and x=5–499 in the 512px image) on a transparent canvas, outside the maskable safe zone. Provide opaque, padded maskable variants or declare these files with purpose Useful? React with 👍 / 👎. |
||
| }, | ||
| { | ||
| "src": "web-app-manifest-512x512.png", | ||
| "sizes": "512x512", | ||
| "type": "image/png", | ||
| "purpose": "maskable" | ||
| } | ||
| ], | ||
| "theme_color": "#ffffff", | ||
| "background_color": "#ffffff", | ||
| "display": "standalone" | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modern browsers selecting this SVG download an 862 KB file containing two embedded 2000×2000 PNGs merely to render a tiny tab icon; the previous favicon was about 150 KB and the new PNG fallback is only 5 KB. This adds roughly 700 KB to a first visit and substantial raster decode work, so the adaptive asset should use actual vector paths or appropriately downsampled embedded images.
Useful? React with 👍 / 👎.