Repository navigation
Simplify Contact copy and use supplied adaptive favicon - #5
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5279f3f898
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "src": "web-app-manifest-192x192.png", | ||
| "sizes": "192x192", | ||
| "type": "image/png", | ||
| "purpose": "maskable" |
There was a problem hiding this comment.
On platforms that apply a mask to installed-app icons, both supplied images can be visibly cropped because their foreground extends nearly edge-to-edge (x=2–187 in the 192px image and x=5–499 in the 512px image) on a transparent canvas, outside the maskable safe zone. Provide opaque, padded maskable variants or declare these files with purpose any so the platform adds the required padding.
Useful? React with 👍 / 👎.
| icon: [ | ||
| { url: assetPath("/images/favicon/favicon.ico"), sizes: "any" }, | ||
| { url: assetPath("/images/favicon/favicon-96x96.png"), type: "image/png", sizes: "96x96" }, | ||
| { url: assetPath("/images/favicon/favicon.svg"), type: "image/svg+xml", sizes: "any" } |
There was a problem hiding this comment.
Modern browsers selecting this SVG download an 862 KB file containing two embedded 2000×2000 PNGs merely to render a tiny tab icon; the previous favicon was about 150 KB and the new PNG fallback is only 5 KB. This adds roughly 700 KB to a first visit and substantial raster decode work, so the adaptive asset should use actual vector paths or appropriately downsampled embedded images.
Useful? React with 👍 / 👎.
1 participant
Remove the specified redundant copy from the Contact header, connect options, and interview form. Move the email and interview buttons closer to their headings while retaining the expandable form, editable detected timezone, consent, validation, and acknowledged Google Sheets submission.
Use the supplied favicon package: an SVG that responds to browser light/dark preference, PNG/ICO fallbacks, Apple touch icon, and manifest icons. Correct the manifest's OpenDQM name and relative asset paths so every icon resolves under the GitHub Pages project prefix.
Validation: ESLint, TypeScript, Prettier, all 41 Vitest tests, production static export, responsive Contact checks at eight widths, keyboard expansion/anchor behavior, light/dark favicon rendering, and manifest asset checks. Confirm the deployed Pages version and a marked live interview submission after both production workflow stages succeed.