Repository navigation
build: fix RPC, Vulkan and SYCL builds after the upstream merge - #421
Merged
Merged
Conversation
- ggml-rpc: the merged tree has 103 ops; update the GGML_OP_COUNT assert and bump RPC_PROTO_PATCH_VERSION. - vulkan: restore vk_op_fwht_signed_push_constants, dropped when upstream moved the push-constant structs into ggml-vulkan-push-constants.h. - sycl: the two fork oneDNN GEMM paths still called the removed get_scratchpad_mem; allocate the scratchpad from the pool as upstream does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
vk_op_fwht_signed_push_constants, lost when upstream moved the push-constant structs intoggml-vulkan-push-constants.h.get_scratchpad_mem; allocate the scratchpad from the pool, as upstream does in the same file.Why
Testing