Repository navigation
Use caret requirements for published dependencies instead of exact pins - #25
Merged
Merged
Conversation
Perry's P0 integration of turnloop 0.1.0-alpha.2 had to downgrade libc (0.2.189 -> 0.2.175), tokio (via mio/rustix), redis (1.6.0 -> 1.2.4, now with a future-incompatibility warning), wasm-bindgen/js-sys/web-sys and tempfile across its whole workspace, because turnloop's manifests pinned libc, windows-sys, wasm-bindgen, js-sys, wasip2/wasip3, getrandom, futures-io and the protocol codecs with '='. A library must not force its consumers' graph. Published crates now use caret requirements at the same minimum versions. turnloop's own builds are unchanged: Cargo.lock still satisfies every manifest under --locked, and the lockfile-based seven-day soak still gates what CI builds. Dev-only pins (loom, gungraun, the publish = false contract crate's wasm-bindgen-test stack) stay exact.
|
Warning Review limit reachedNext included review available in 49 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Sep 15, 2026
proggeramlug
pushed a commit
to PerryTS/perry
that referenced
this pull request
Sep 15, 2026
alpha.2 pinned its own dependencies with '=', which forced this workspace to downgrade libc 0.2.189 -> 0.2.175 (and tokio, redis, wasm-bindgen, mio, rustix, tempfile). On Linux that broke the build outright: libc 0.2.175 has no backtrace_symbols_fd, which perry-runtime's quarantine and exception reporters call on glibc, so only macOS builds passed. turnloop 0.1.0-alpha.3 uses caret requirements (PerryTS/turnloop#25). The lockfile is main's with turnloop added, so every other crate is back to the version main already soaked. Checksum c3370511f37b90dc5ba694566cb941f0e89c205c84b798277f17a05f13e4a8ab, resolved once with CARGO_RESOLVER_INCOMPATIBLE_PUBLISH_AGE=allow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Perry's P0 integration of turnloop 0.1.0-alpha.2 had to downgrade shared dependencies across Perry's whole workspace, because turnloop pinned them exactly with
=:A library must not force its consumers' dependency graph.
Cargo.lockstill satisfies every manifest under--locked, and the lockfile-based 7-day soak still gates what CI builds.publish = falsecontract crate's wasm-bindgen-test stack.Should land before 0.1.0-alpha.3 is published.