Skip to content

release-plz: allow our own just-published siblings during resolution - #33

Merged
proggeramlug merged 1 commit into
mainfrom
fix/release-plz-sibling-age
Sep 15, 2026
Merged

proggeramlug merged 1 commit into
mainfrom
fix/release-plz-sibling-age

Conversation

@proggeramlug

@proggeramlug proggeramlug commented Sep 15, 2026 •

Copy link
Copy Markdown
Contributor

main CI after #32 failed in release-pr: release-plz runs cargo update per crate, resolving siblings from the registry, and our 7-day publish-age soak rejects versions published hours earlier:

error: failed to select a version for the requirement `turnloop-io = "^0.1.0-alpha.3"`
  version 0.1.0-alpha.3 is too new (published 2 hours ago, minimum age 7 days)

Caret requirements (#25) made this reachable; the old = pins hid it.

The soak protects third-party supply chain, and this resolution produces no artifact: any lockfile the release PR carries is still gated by scripts/ci/soak.py in required CI, which this step cannot bypass. lint-workflows.py (actionlint, zizmor, shellcheck) passes.

Summary by CodeRabbit

  • Chores
    • Updated release automation to streamline version resolution during publishing.
    • Existing publish-age validation remains enforced through required continuous integration checks.

main CI run after #32 failed in release-pr: release-plz runs cargo update per
crate, which resolves siblings from the registry, and the seven-day soak
rejects versions we published hours earlier ('turnloop-io = ^0.1.0-alpha.3 is
too new'). Caret requirements (#25) made this reachable; exact pins hid it.

The soak protects third-party supply chain, and this resolution produces no
artifact: any lockfile the release PR carries is still gated by
scripts/ci/soak.py in required CI, which this step cannot bypass.
@coderabbitai

coderabbitai Bot commented Sep 15, 2026 •

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 54e0102e-d370-40df-8dc7-b5e18bc3158d

📥 Commits

Reviewing files that changed from the base of the PR and between e949b02 and b6c38f8.

📒 Files selected for processing (1)
  • .github/workflows/release.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The release workflow now allows release-plz to resolve workspace siblings that are newer than the registry publish-age threshold. Required CI continues to enforce the soak through scripts/ci/soak.py.

Changes

Release workflow

Layer / File(s) Summary
Publish-age resolution
.github/workflows/release.yml
The release-pr release-plz step sets CARGO_RESOLVER_INCOMPATIBLE_PUBLISH_AGE: allow. The workflow comment states that scripts/ci/soak.py continues to enforce the soak in required CI.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to b6c38

Release-time sibling resolution is relaxed without removing the required seven-day dependency-age protection, so the change is ready to merge.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: allowing release-plz to resolve workspace sibling packages that were just published.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/release-plz-sibling-age

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@proggeramlug
proggeramlug merged commit 09d205f into main Sep 15, 2026
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant