Repository navigation
release-plz: allow our own just-published siblings during resolution - #33
Conversation
main CI run after #32 failed in release-pr: release-plz runs cargo update per crate, which resolves siblings from the registry, and the seven-day soak rejects versions we published hours earlier ('turnloop-io = ^0.1.0-alpha.3 is too new'). Caret requirements (#25) made this reachable; exact pins hid it. The soak protects third-party supply chain, and this resolution produces no artifact: any lockfile the release PR carries is still gated by scripts/ci/soak.py in required CI, which this step cannot bypass.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe release workflow now allows release-plz to resolve workspace siblings that are newer than the registry publish-age threshold. Required CI continues to enforce the soak through ChangesRelease workflow
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to Release-time sibling resolution is relaxed without removing the required seven-day dependency-age protection, so the change is ready to merge. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
main CI after #32 failed in
release-pr: release-plz runscargo updateper crate, resolving siblings from the registry, and our 7-day publish-age soak rejects versions published hours earlier:Caret requirements (#25) made this reachable; the old
=pins hid it.The soak protects third-party supply chain, and this resolution produces no artifact: any lockfile the release PR carries is still gated by
scripts/ci/soak.pyin required CI, which this step cannot bypass.lint-workflows.py(actionlint, zizmor, shellcheck) passes.Summary by CodeRabbit