Sungrow PV Inverter and ESS Implementation by tsicking · Pull Request #3935 · OpenEMS/openems

tsicking · 2026-08-31T15:28:56Z

Updated version of Sungrow implementation. Replaces #2528
This version is used on a handful of productive systems run by opernikus.

codecov · 2026-08-31T15:31:30Z

Codecov Report

❌ Patch coverage is 79.97054% with 136 lines in your changes missing coverage. Please review.

Additional details and impacted files

@@              Coverage Diff              @@
##             develop    #3935      +/-   ##
=============================================
- Coverage      58.34%   55.46%   -2.88%     
- Complexity     19469    19533      +64     
=============================================
  Files           3306     3861     +555     
  Lines         161114   178070   +16956     
  Branches       11953    14818    +2865     
=============================================
+ Hits           93993    98743    +4750     
- Misses         63425    75440   +12015     
- Partials        3696     3887     +191

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

sfeilmeier

See my remarks. Same applies to other similar files.

Who can work on these topics?

sfeilmeier · 2026-09-02T15:28:16Z

+	String ess_id() default "ess0";
+
+	@AttributeDefinition(name = "ESS target filter", description = "This is auto-generated by 'ESS-ID'.")
+	String ess_target() default "(enabled=true)";


Please replace with ReferenceConfigurationPlugin

sfeilmeier · 2026-09-02T15:29:23Z

+	}
+
+	private void mapChannelValues() {
+		this.ess.getTotalDcPowerChannel().onSetNextValue(value -> {


Why do you not map those Registers directly?

So the alternative would be to make this a ModbusComponent, read the registers here and leave them out in the ESS implementation? This would mean that you send more modbus tasks per second but you can remove some channels from the ESS, right?
I have no strong opinion which is better, but this was the first thing that came into my mind. I just had a look at the GoodWe implementations and saw that the single string chargers have their own modbus protocol, while the two string chargers don't.
Now, as I write, one more options comes into my mind. If the charger is referenced in the ESS and not the other way round, one could do something like the following in the modbus protocol:

m(new UnsignedDoubleWordElement(5016)).build() // .onUpdateCallback(value -> this.charger._setActualPower(value)), //

Is that what you have in mind?

Ok, I did not realize this is actually copying from ess component. Then it's ok. Only flaw is, that you would have to remove the listener on deactivate, otherwise the garbage collector will not be able to cleanup.

sfeilmeier · 2026-09-02T15:33:16Z

+	 *
+	 * @param value the next value
+	 */
+	public default void _setGridMode(GridMode value) {


No, it was replaced with ChannelUtils.setValue() by purpose. Please reset to develop.

Okay, I see. I was wondering why this method disappeared. For what reason do you use ChannelUtils.setValue()?
The same then for ManagedSymmetricEss._setAllowedChargePower() I guess? But why is ManagedSymmetricEss._setAllowedDischargePower() still there?

sfeilmeier · 2026-09-19T18:32:57Z

+	@Reference
+	private ConfigurationAdmin cm;
+
+	@Reference(policy = ReferencePolicy.STATIC, policyOption = ReferencePolicyOption.GREEDY, cardinality = ReferenceCardinality.MANDATORY)


If you use GenerateTargetsFromReferences, you have to set the target property here - see documentation: https://github.com/OpenEMS/openems/blob/develop/io.openems.core.referencetarget/readme.adoc

sfeilmeier · 2026-09-19T18:34:18Z

+		this.config = config;
+		super.activate(context, config.id(), config.alias(), config.enabled());
+
+		if (OpenemsComponent.updateReferenceFilter(this.cm, this.servicePid(), "ess", config.ess_id())) {


Also this is obsolete then

sfeilmeier · 2026-09-19T18:36:59Z

+	}
+
+	private void mapChannelValues() {
+		this.ess.getTotalDcPowerChannel().onSetNextValue(value -> {


Ok, I did not realize this is actually copying from ess component. Then it's ok. Only flaw is, that you would have to remove the listener on deactivate, otherwise the garbage collector will not be able to cleanup.

sfeilmeier · 2026-09-19T18:38:55Z

+
+@ObjectClassDefinition(//
+		name = "ESS Sungrow", //
+		description = "Implements the Sungrow SH10RT Hybrid Ess")


Do you know how different the protocols of Sungrow devices are? Should we probably rename the Factory-ID to something like Ess.Sungrow.Hybrid.* to have a namespace for future implementations?

sfeilmeier · 2026-09-19T18:46:33Z

+				"Modbus", config.modbus_id())) {
+			return;
+		}
+		this.getActivePowerChannel().onSetNextValue(value -> { //


ElectricityMeter .calculatePhasesFromActivePower() does exactly this

sfeilmeier · 2026-09-19T18:48:01Z

@@ -0,0 +1,25 @@
+package io.openems.edge.sungrow.dccharger;
+
+import org.junit.Test;


JUnit4 is deprecated. Please use Juniper

sfeilmeier · 2026-09-19T18:48:40Z

+		new ComponentTest(new SungrowDcChargerImpl()) //
+				.addReference("cm", new DummyConfigurationAdmin()) //
+				.addReference("ess", new EssSungrowImpl()) //
+				.activate(MyConfig.create() //


I can only recommend having one test with strict-mode for Modbus devices.

tsicking added 9 commits August 31, 2026 11:35

Implementation of Sungrow components

519c1f0

Fixed merge problems

a824192

Added JUnit tests

94cb8d6

Added interfaces for grid meter and DC charger

3e1f01f

Added Sungrow to EdgeApp

8a98719

Prepare commit

3d8c8d1

Merge branch 'develop' into feature/Sungrow

cbffee5

Removed duplicated entry

13fb2c6

Implemented getSurplusPower()

b76f154

tsicking requested a review from Sn0w3y August 31, 2026 15:28

tsicking mentioned this pull request Aug 31, 2026

Sungrow String and ESS Implementation #2528

Closed

sfeilmeier added 2 commits September 2, 2026 15:16

Merge remote-tracking branch 'origin/develop' into feature/Sungrow

db25878

Apply tools/prepare-commit.sh

0ed05dc

sfeilmeier requested changes Sep 2, 2026

View reviewed changes

tsicking and others added 5 commits September 3, 2026 14:25

Removed default settings

836613c

Use ReferenceConfigurationPlugin

7aa9098

Merge remote-tracking branch 'origin/develop' into feature/Sungrow

b6c33f1

Cleanup

18fa989

Review

7053559

sfeilmeier reviewed Sep 19, 2026

View reviewed changes

Add author and docs

ccde13b

sfeilmeier approved these changes Sep 19, 2026

View reviewed changes

Add professional support link

eae03b8

sfeilmeier merged commit 9b0353a into OpenEMS:develop Sep 19, 2026
2 checks passed

		@@ -0,0 +1,25 @@
		package io.openems.edge.sungrow.dccharger;

		import org.junit.Test;

Conversation

tsicking commented Aug 31, 2026

Uh oh!

codecov Bot commented Aug 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sfeilmeier left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov Bot commented Aug 31, 2026 •

edited

Loading