Sungrow String and ESS Implementation

[Sn0w3y]

Based on the Implementation of @clehne in opernikus-common fork.
I adapted it to use ElectricityMeter

Thanks to them

[sfeilmeier]

We have too many open PRs with similar issues. I suggest we work on #2566 first (see the discussions on Coding Guidelines there). Afterwards we can re-open these PRs one at a time. Thanks!

[github-actions]

[Giermann]

Any news on this?
@tsicking would I be forced to merge the PR myself for my first experience with OpenEMS or is there any schedule planned to accept this PR?

[Sn0w3y]

Closed as i guess it is a WIP

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

❗ There is a different number of reports uploaded between BASE (a7efc1c) and HEAD (fe96aa3). Click for more details.

HEAD has 1 upload less than BASE

Flag	BASE (a7efc1c)	HEAD (fe96aa3)
java	1	0

Additional details and impacted files

@@              Coverage Diff               @@
##             develop    #2528       +/-   ##
==============================================
- Coverage      55.70%   28.56%   -27.14%     
==============================================
  Files           3674      404     -3270     
  Lines         172011    12905   -159106     
  Branches       14175     2324    -11851     
==============================================
- Hits           95810     3685    -92125     
+ Misses         72409     9058    -63351     
+ Partials        3792      162     -3630     

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[tsicking]

Any news on this? @tsicking would I be forced to merge the PR myself for my first experience with OpenEMS or is there any schedule planned to accept this PR?

We are still working on it and we are testing it thoroughly. I will update this PR when we are done. You can merge it yourself and can use it as a starting point.

[nishad-apollo]

@tsicking Any update on the sungrow inverter and ESS support for openEMS ? I can't find this anywhere.

[sfeilmeier]

@nishad-apollo: Can you actually test the implementation with hardware? I could then re-open this PR for you and clean it up (e.g. moving everything to one common io.openems.edge.sungrow bundle)

[nishad-apollo]

@nishad-apollo: Can you actually test the implementation with hardware? I could then re-open this PR for you and clean it up (e.g. moving everything to one common io.openems.edge.sungrow bundle)

Sure, I want to test the bundle but not able to find in the develop branch, could you let me know then I could test it once. Is sungrow ESS and inverter still WIP or already released ?

[sfeilmeier]

It's not officially released yet.
The latest "close to official" branch is here: https://github.com/Sn0w3y/openems/tree/Sungrow-ESS-and-Sungrow-PV-Inverter
If you are able to test it, we should be able to make it official relatively quickly. When are you planning to test it?

[nishad-apollo]

Got it..

I got redirected to https://github.com/opernikus-common/openems from the comment section. Is this correct too ? Looks like forked from this repo. Or should i consider this specifically ? https://github.com/Sn0w3y/openems/tree/Sungrow-ESS-and-Sungrow-PV-Inverter

Test - Yes, Will start testing Next month, trying to figure the build now. Will update here, It will be great to make this official.

[nishad-apollo]

It's not officially released yet.

The latest "close to official" branch is here: https://github.com/Sn0w3y/openems/tree/Sungrow-ESS-and-Sungrow-PV-Inverter

If you are able to test it, we should be able to make it official relatively quickly. When are you planning to test it?

Could you also let me know the modbus mapping datasheet followed for both ESS and PV here ? It will help alot.

[tsicking]

Hi, it seems this PR is based on a very old version of ours. We have improved our Sungrow implementation since then and use it on several productive systems.
I can have a look at it and compare it to our latest version. I may find time for it today or tomorrow.

[sfeilmeier]

@tsicking Good to know. In that case you don't need to compare. Just open up a new PR and I'll close this one.

[sfeilmeier]

@tsicking Any update on this or should we proceed with the old version? I just want to avoid a lot of merge problems for you later.

[tsicking]

@tsicking Any update on this or should we proceed with the old version? I just want to avoid a lot of merge problems for you later.

I'm working on it... I had some merge problems myself, but I'm almost through.

[tsicking]

Replaced by #3935