Repository navigation
v0.2: ping/pong, stricter names, forward-compatible server messages - #2
Merged
Merged
Conversation
From the first app implementation (OpenRadlr): - The state in join does not count towards max_update_hz; rate_limited does not count towards too_many_errors. - Names must not contain Cc, Cf (except ZWJ), Co, Zl or Zp characters or be only whitespace; receivers display names as plain text. - Apps ignore unknown server message types and accept unknown error codes and leave reasons. - New ping/pong messages so apps (also in browsers, which cannot see WebSocket pings) can detect a dead server. - welcome.protocol is now 0.2. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit d0446d5)
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Spec changes from the first app implementation (OpenRadlr, Lethonium/OpenRadlr#37), which tested v0 live against the reference server.
welcome.protocolbecomes"0.2".joindoes not count towardsmax_update_hz, so an app may sendupdateright afterjoin.rate_limiteddoes not count towardstoo_many_errors. Before this, a backend that joined and updated 20+ riders at once was disconnected, and the same thing happened again on every reconnect.type, and must accept unknownerror.code(acting onfatal) andleft.reasonvalues.pingmessage, answered withpongcarrying theref. Browsers can't see WebSocket pings, so apps need an app-level message. An app that has received nothing for 20 s should ping, and may treat the connection as closed after 10 s more. Apps that see WebSocket pings may use a 45 s rule instead.Examples added:
app/ping.json,server/pong.json,app/join-emoji-name.json, and seven invalid names.Test plan
python3 tools/validate.py: every spec JSON block has a matching example, examples match the schemas, and each invalid name fails the schema🤖 Generated with Claude Code