Repository navigation
Protocol v0.2: OpenRadlr feedback - #2
Merged
Merged
Conversation
- A join no longer starts the rate-limit clock, so an update right after a join is accepted; rate_limited no longer counts towards too_many_errors. - Reject names with Cc, Cf (except ZWJ), Co, Zl or Zp characters, or only whitespace. - Answer ping with pong; welcome.protocol is now 0.2. - Fake app riders are named Fake 1..N. - Record the feedback and the decisions in docs/. - Move the protocol submodule to the v0.2 spec. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements protocol v0.2 (OpenBikeNet/protocol#2), which resolves the feedback from the first app implementation (OpenRadlr). The feedback and the decision on each point are in
docs/2026-11-07-feedback-from-openradlr.md.presence: a join no longer starts the rate-limit clock (last_update, separate from the timeout'slast), so an update right after a join is acceptedws:rate_limitedis still sent but does not count towardstoo_many_errors, so a backend with many riders can't be disconnected in a loop by one early tick.pingis answered withpong(with theref).welcome.protocolcomes from the newPROTOCOL_VERSION("0.2")protocol: names with Cc, Cf (except ZWJ), Co, Zl or Zp characters, or only whitespace, getinvalid_value. The ranges are the same as in the schemasobn-fake-app: riders areFake 1…N(fake-1…N) so they don't read as an app's local botsBuilds on OpenBikeNet/protocol#2 (merged): the submodule points at its merge commit
e00bdb6.Test plan
make check(rustfmt, clippy-D warnings,cargo test --workspace): 67 tests greenping→pongwith and withoutref;pongmatches its example; the new valid and invalid name examples parse or fail withinvalid_value🤖 Generated with Claude Code