Repository navigation
Bins: the leftovers from the finger-slot and raised-letter reviews, and "1 unit" - #68
Merged
Merged
Conversation
The bin audit's "counted as with no lip" check gave the two slotted rows that ask for holes the bin counted without the lip's rule (lipTaken), which is what dividersBuilt asks itself, so it could not fail on them. Every row is now held to the same bin with no lip and no holes: those two build no holes, as theirs give way to the back slot. It passes here, and on eb32f00 it fails on exactly those two rows, the #58-SF-C bins (1 plate along where 2 fit, and 1 where 4 do), where the old form passed. (#58 nit 1) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Uqqb1cvhXxrpb3P6y6ykBY
dividersWhy had 'slot', with its own wording in Checks, for a bin with a finger slot between the plates its lip allows but none between the plates without it, built with the lip's count all the same. No bin can be: the lip stops only plates that would stand under 6 mm apart, and keeps them under 9, where a finger slot needs 15 mm between two plates' rails, so the walls those plates meet have no slot with either count; and all else a slot is settled by is the same with either. None of 900,000 random bins nor 1,020,600 aimed at the lip reached it. The branch and its wording go, dividersWhy's comment and ENGINE.md say why, and a new audit row, "counted with no lip", holds 1,296 slotted bins counted without their lip (160 where the lip would hold their plates) to being built with that count and never put down to the lip; with dividersBuilt made to keep the lip's count where the other leaves a single slot, it finds 112 wrong. (#58 O4) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Uqqb1cvhXxrpb3P6y6ykBY
The last commit set "counted with no lip" two lines into the comment over the opt-in rows, which left the audit unable to load. It now stands between the rows before and that comment, which is whole again. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Uqqb1cvhXxrpb3P6y6ykBY
The comments on lipNotched, dividersBuilt and countedAs, and ENGINE.md, said only the lip's rule reads lipTaken. lipNotched does, which drops the lip's rule and its corners from the count and from the reasons dividersWhy gives, as it asks railedLimit and plateLayout of the marked bin; and the page's setDividerLimit reads it to hold the field for the plates across to dividersBuilt's count. Each now says so. Comments only. (#58 nit 2) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Uqqb1cvhXxrpb3P6y6ykBY
Since #62 a note's shells are kept 0.02 mm clear of each other's corners in x or y wherever a move allows (NOTE_APART), not "closer than a slicer's weld joins"; and the 15 µm the random notes are held to is the audit's own figure, as noteShells holds its fallback to none. Comments only. (#62 nits) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Uqqb1cvhXxrpb3P6y6ykBY
Where one unit is the tallest bin that fits, the grid summary said "tallest single bin 1 units", and a 1-unit bin's tooltips on the map and in the preview, and the preview's label in focus, said "1 units" too. All four count with plural() now. A new bins.spec test, an 18 mm drawer over a 4.25 mm plate, checks all four; it fails on main. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Uqqb1cvhXxrpb3P6y6ykBY
…asks again A refresh asks a bin's dividers (builtDivs) ten times over, for its key, its name, Checks and its compartments, and Checks asks dividersWhy of every bin with removable plates. With 63 such bins with finger slots ticked, dividersBuilt took 60 to 150 ms of an 85 to 180 ms refresh, about three quarters of it, and 20 to 45 of 35 to 85 with no slots; with all 63 asking for more plates than fit, dividersWhy took 20 to 45 more. Both are pure, so the page keeps each answer by the settings that asked it, as it keeps fingerPlan's, and clears the lot past 500. The same refreshes now take 12 to 50 ms, or 30 to 85 with all 63 short. 2,400 bins built at random on the page get the same answer kept as asked fresh. (#58 O5) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Uqqb1cvhXxrpb3P6y6ykBY
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Uqqb1cvhXxrpb3P6y6ykBY
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Uqqb1cvhXxrpb3P6y6ykBY
5 of 6 tasks
Oliver-Johnson
pushed a commit
that referenced
this pull request
Oct 9, 2026
Only sw.js conflicted; the pages are rebuilt from the merged sources. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Uqqb1cvhXxrpb3P6y6ykBY
4 of 6 tasks
Oliver-Johnson
pushed a commit
that referenced
this pull request
Oct 9, 2026
Only sw.js conflicted, on its VERSION line: took main's and rebuilt the pages. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XjNf7SQF9o4ZVeWiSbWQmk
3 tasks done
Oliver-Johnson
added a commit
that referenced
this pull request
Oct 9, 2026
Bins review follow-ups from #68, and the reload test over HTTP
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Oliver · project thread
Part of #21
The Bins optionals left from the reviews of #58 (finger slots) and #62 (four small Bins fixes).
What this changes
Before:
lipTaken). That is whatdividersBuiltasks itself, so those two rows could not fail it.lipNotched,dividersBuiltandcountedAs, and docs/ENGINE.md, said only the lip's rule readslipTaken.dividersWhyand the page'ssetDividerLimitread it too.dividersWhyhad a 'slot' reason, with its own Checks wording, for a slotted bin built with the count its lip allows. No bin swept had reached it.builtDivsof each bin about ten times (its key, its name, Checks, its compartments). With 63 bins with removable plates and finger slots ticked, 60 to 150 ms of an 85 to 180 ms refresh went ondividersBuilt, about three quarters of it; with no slots, 20 to 45 ms of 35 to 85. Checks asksdividersWhyof every bin built with fewer plates than it asks for: 21 such bins spent 1 to 9 ms, and with all 63 short it took 20 to 45 ms more of a 130 to 220 ms refresh.After:
dividersBuiltis as on main), and on eb32f00's engine it fails on exactly the two Bins: a finger slot in the top of any wall #58-SF-C rows ("0 and 2 fit with no lip", "0 and 4 fit with no lip"). The old form said nothing about them there; they failed only on the shelf and fixture checks.lipNotcheddrops the lip's rule and its corners (in the count, and individersWhy's reasons, which asksrailedLimitandplateLayoutof the marked bin), andsetDividerLimitholds the field for plates across todividersBuilt's count.dividersWhy's comment and ENGINE.md say why. A new audit row holds slotted bins aimed at the lip to being built with the count without their lip and never put down to the lip.builtDivsanswer, and eachdividersWhyanswer Checks asks for, by the settings that asked it, as it keepsfingerPlan(39cbcc8), and clears each past 500. The same layouts now refresh in 12 to 50 ms, and in 30 to 85 ms with all 63 short.NOTE_APART), and 15 µm is a figure of the audit's own.How:
dividersWhynever gives 'slot'. The widest the lip's plates stood was 4.93 mm.dividersWhymust not name the lip. WithdividersBuiltchanged to keep the lip's count where the count without leaves a single slot, it reports 112 wrong.keptDivsandkeptWhysin src/bins/ui.js, keyed likefingerPlansbybinCfg(and, forkeptDivs, whether the bin has a size of its own). Checks asksdivsWhy, which keepsdividersWhy's answers. In the page, 2,400 bins changed in place (and the plate, clearance, hole fit and smoothness changed under them) gave the same dividers and the same reasons kept as worked out afresh. Timed with 63 bins in five layouts, at a load average of 3 to 11, so the ranges are wide.plural(n, 'unit')in the grid summary, the map's tooltip, the preview's tooltip and the preview's label.keptDivs,keptWhys,divsWhy. Removed: none. No clash with main or Keep a pasted link over a waiting save, and a size the drawer could not take #65 (c149524).Checks
src/, not the generatedindex.html/bins/index.htmlnode build.jsand committed the regenerated pages alongside the sources.node build.js --checkis clean on the head.npm testpasses on the head (bin audit "all cases clean", plate audit "all plates watertight and every shell facing outwards", "all checks pass", and the rest), andnode test/ci-sim.jssays "CI will pass."-c .pw-local.config.js --workers=2). The rest oftest:allwas not run here.If this touches geometry
node test/bin-audit.jsreportsall cases clean.dividersBuilt,binDividers,railedLimitboth ways,countedAsanddividersWhy. The first 30,000 include 15,454 asking for finger slots, 12,174 asking for removable plates, 5,972 with holes, 13,527 with a label shelf, 8,079 with a raised note and 3,712 counted without their lip.dividersWhy, and so Checks, changes for none of them under O4. The engine's code differs from main only individersWhy's two lines.🤖 Generated with Claude Code
https://claude.ai/code/session_01Uqqb1cvhXxrpb3P6y6ykBY
Generated by Claude Code