Repository navigation
Bins review follow-ups from #68, and the reload test over HTTP - #71
Merged
Merged
Conversation
…n check can fail The row only asked for counts at or under what fits, and Checks gives a reason only for a count put down, so a dividersWhy that asked the wrong bin passed it. With one more than fits each way and 40 by 40 it catches that (80 wrong); main passes. The SF-C comment now says the 2.5 x 0.5 row's holes give way to its front slot as well. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Uqqb1cvhXxrpb3P6y6ykBY
It failed once from file:// under load and passed when run again; from file:// the browser has now and then lost what a page stored before it (see serveRoot). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Uqqb1cvhXxrpb3P6y6ykBY
…sured Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Uqqb1cvhXxrpb3P6y6ykBY
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Uqqb1cvhXxrpb3P6y6ykBY
Oliver-Johnson
pushed a commit
that referenced
this pull request
Oct 9, 2026
Only sw.js conflicted; the pages are rebuilt from the merged sources. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Uqqb1cvhXxrpb3P6y6ykBY
5 of 6 tasks
Oliver-Johnson
pushed a commit
that referenced
this pull request
Oct 9, 2026
Only sw.js conflicted, on its VERSION line: took main's and rebuilt the pages. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XjNf7SQF9o4ZVeWiSbWQmk
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Oliver · project thread
Part of #21
The optionals from #68's review, and the one test that failed in it once.
What this changes
Before:
dividersWhyhad nothing to judge: the reviewer's mutant,dividersWhyaskingrailedLimitandplateLayoutof the bin as given rather than the one marked without its lip, passed it.builtDivscomment in src/bins/ui.js said a refresh asks each bin about ten times. The reviewer measured about fifteen.After:
H.serveRoot(), as the test after it does.binsJob(page, url)passes the URL on toH.openBins. The comment says why: the likeliest cause is the oneserveRootdescribes, the browser now and then losing from file:// what a page stored before it (inferred, not reproduced).How:
Checks
src/, not the generatedindex.html/bins/index.htmlnode build.jsand committed the regenerated pages alongside the sources.node build.js --checkis clean on the head.npm testpasses on the head (bin audit "all cases clean", plate audit "all plates watertight and every shell facing outwards", "all checks pass"), andnode test/ci-sim.jssays "CI will pass."-c .pw-local.config.js --workers=2). The rest oftest:allwas not run here.If this touches geometry
node test/bin-audit.jsreportsall cases clean, with the wider row.🤖 Generated with Claude Code
https://claude.ai/code/session_01Uqqb1cvhXxrpb3P6y6ykBY
Generated by Claude Code