Skip to content

Bins review follow-ups from #68, and the reload test over HTTP - #71

Merged
Oliver-Johnson merged 4 commits into
mainfrom
claude/bins-review-followups
Oct 9, 2026
Merged

Oliver-Johnson merged 4 commits into
mainfrom
claude/bins-review-followups

Conversation

@Oliver-Johnson

Copy link
Copy Markdown
Owner

Requested by Oliver · project thread

Part of #21

The optionals from #68's review, and the one test that failed in it once.

What this changes

Before:

  • Optional 1. The bin audit's "counted with no lip" row asked each bin for plates at or below what fits. Checks gives a reason only for a count it puts down, so the row's check on dividersWhy had nothing to judge: the reviewer's mutant, dividersWhy asking railedLimit and plateLayout of the bin as given rather than the one marked without its lip, passed it.
  • Optional 2. The builtDivs comment in src/bins/ui.js said a refresh asks each bin about ten times. The reviewer measured about fifteen.
  • Optional 4. The comment on the slotted rows' no-lip check (bin-audit.js:3599) said their holes give way "to the back slot". On the 2.5 x 0.5 bin they give way to the front slot too.
  • estimate.spec.js, "a price survives a reload". It failed once in the review under load (1 of 243) and passed 12 of 12 when run again, on Bins: the leftovers from the finger-slot and raised-letter reviews, and "1 unit" #68's head and on main. It ran from file://.

After:

  • Optional 1. The row also asks for one more plate across than fits, one more along, and 40 each way, and its comment says why. It now covers 5,184 bins: 1,944 counted without their lip, 240 where the lip would hold their plates. It passes here, and with the mutant it reports "WRONG in 80" (Checks names the lip).
  • Optional 2. The comment says "about fifteen times over".
  • Optional 4. The comment says "(and on the 2.5 x 0.5 to the front one too)".
  • The reload test runs over HTTP through H.serveRoot(), as the test after it does. binsJob(page, url) passes the URL on to H.openBins. The comment says why: the likeliest cause is the one serveRoot describes, the browser now and then losing from file:// what a page stored before it (inferred, not reproduced).

How:

  • Test and comment changes only. The engine is untouched, and the one source change is a comment, so the pages differ from main only in that comment (bins/index.html) and the cache version (sw.js).
  • Optional 3 (017b222 doesn't load the audit) stays as it is: it is merged history.
  • No new top-level names.

Checks

  • I edited the sources in src/, not the generated index.html / bins/index.html
  • I ran node build.js and committed the regenerated pages alongside the sources. node build.js --check is clean on the head.
  • npm test passes on the head (bin audit "all cases clean", plate audit "all plates watertight and every shell facing outwards", "all checks pass"), and node test/ci-sim.js says "CI will pass."
    • test/ui/estimate.spec.js: 27 passed (-c .pw-local.config.js --workers=2). The rest of test:all was not run here.

If this touches geometry

  • Bins: no shape changes. node test/bin-audit.js reports all cases clean, with the wider row.
  • Baseplates: not touched.
  • I added a case covering the new shape: no new shape; three more counts on the existing row.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Uqqb1cvhXxrpb3P6y6ykBY


Generated by Claude Code

claude added 4 commits October 9, 2026 09:34
…n check can fail

The row only asked for counts at or under what fits, and Checks gives a reason only
for a count put down, so a dividersWhy that asked the wrong bin passed it. With one
more than fits each way and 40 by 40 it catches that (80 wrong); main passes. The
SF-C comment now says the 2.5 x 0.5 row's holes give way to its front slot as well.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Uqqb1cvhXxrpb3P6y6ykBY
It failed once from file:// under load and passed when run again; from file:// the
browser has now and then lost what a page stored before it (see serveRoot).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Uqqb1cvhXxrpb3P6y6ykBY
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Uqqb1cvhXxrpb3P6y6ykBY
@Oliver-Johnson Oliver-Johnson self-assigned this Oct 9, 2026
@Oliver-Johnson
Oliver-Johnson merged commit 3145cc7 into main Oct 9, 2026
3 checks passed
@Oliver-Johnson
Oliver-Johnson deleted the claude/bins-review-followups branch October 9, 2026 10:18
Oliver-Johnson pushed a commit that referenced this pull request Oct 9, 2026
Only sw.js conflicted; the pages are rebuilt from the merged sources.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Uqqb1cvhXxrpb3P6y6ykBY
Oliver-Johnson pushed a commit that referenced this pull request Oct 9, 2026
Only sw.js conflicted, on its VERSION line: took main's and rebuilt the pages.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XjNf7SQF9o4ZVeWiSbWQmk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants