Repository navigation
Adopt approved OctoSense icon family with local overrides - #555
Merged
Merged
Conversation
Ship 28 original SVG replacements and the original Rinx PNG, including the C5 Night rose Browser compass. Apply explicit OctoSense app-ID overrides while preserving unowned upstream icons and third-party artwork, with shared platform framing and validation evidence.
This was referenced Oct 21, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OctoSense's launcher inherits most app artwork from Makepad, while several identities share a generic fallback. Apply the approved OctoSense family: 28 original SVG icons plus the unchanged original Rinx PNG, including the simplified Clock, uniform Sheets cells and C5 Night rose Browser compass.
Keep replacements in the shared shell as an explicit app-ID overlay on Makepad's catalog. Local identities win consistently across styles; new or unowned upstream icons and installed
hub:apps retain their own artwork. No Makepad theme files, dependency pins or runtime patches change. Shared platform framing remains authoritative, with outline variants for Omarchy. Mail and Calendar also include the approved artwork in their system bundles.Includes bilingual design/maintenance guidance, editable sources, Browser design comparisons and production-renderer evidence under
docs/design/icon-family/.Validation:
mobile-apps, Home'smobile-appscheck, and both dependency-graph checks pass.docs/design/icon-family/implementation-validation.json.Platform-style previews run on macOS. Native Android/iOS/Windows/Linux device rendering is unverified; no device was assigned. Validation uses isolated local fixtures and does not claim real model calls or external business effects.
New-app authoring is now documented in OctoSense AGENTS.md, launcher guidance and the bilingual family guide. Matching App Hub guide/template changes and App Flow instructions/scaffolds carry the same format into future apps. The new guidance keeps store apps on their own canonical bundle artwork instead of adding them to the built-in overlay.
Authoring validation: App Hub and App Flow relative-link checks pass with 0 broken links; all changed OctoSense Markdown targets resolve. The onboarding suite ran 39 tests (34 passed, 5 optional build tests skipped), and a fresh tools/octo new app inherits the exact shared SVG and instructions. Disposable starters pass icon file admission and retain only their expected missing-entry/screenshot refusals; no screenshot placeholders were created. Native UI/devices were not exercised for the authoring changes.