Skip to content

Close HUB-05: drop dead android navigation checks #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guofoo merged 1 commit into from
Oct 3, 2026
Merged

Close HUB-05: drop dead android navigation checks #270

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions crates/shell/src/mobile_surface.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1173,8 +1173,7 @@ impl PhoneSurface {
} else {
let bottom=rect(screen.pos.x,screen.pos.y+screen.size.y-24.0,screen.size.x,24.0);
if phone.screen==PhoneScreen::App || phone.keyboard>0.5 {
let band=if android {rect(bottom.pos.x,bottom.pos.y,bottom.size.x,bottom.size.y+phone.insets.bottom)} else {bottom};
self.rounded(cx,band,0.0,if state.style.dark {rgb(28,28,31)}else{rgb(244,244,248)});
self.rounded(cx,bottom,0.0,if state.style.dark {rgb(28,28,31)}else{rgb(244,244,248)});
}
let nav_ink=if phone.screen==PhoneScreen::App || phone.keyboard>0.5 {
if state.style.dark {rgb(238,238,242)}else{rgb(30,30,34)}
Expand All @@ -1187,7 +1186,7 @@ impl PhoneSurface {
let cue_ink=if phone.screen==PhoneScreen::Home {ink}else{nav_ink};
self.rounded(cx,cue,10.0,alpha(cue_ink,0.12));
self.d.icon_centered(cx,Ico::ChevronUp,cue,12.0,alpha(cue_ink,0.90));
} else if !(android && phone.insets.bottom>0.0) {
} else {
self.rounded(cx,rect(bottom.pos.x+bottom.size.x*0.5-60.0,bottom.pos.y+12.0,120.0,4.0),2.0,nav_ink);
}
self.hits.push((bottom,PhoneHit::Home));
Expand Down
8 changes: 7 additions & 1 deletion phone/BACKLOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -673,7 +673,7 @@ Found in the review of the second sync from mobile on 2026-09-25
sync; an old id stays in Android placements and in `wm/launcher.hides`.
Unneeded while the public catalog is empty.

- [ ] **HUB-05 — P3: Small cleanups after the App Hub merge.**
- [x] **HUB-05 — P3: Small cleanups after the App Hub merge.**

- `apps::is_linked` (`crates/shell/src/apps.rs`) is called only by its
test.
Expand All @@ -687,6 +687,12 @@ Found in the review of the second sync from mobile on 2026-09-25
`<id> names no app for the card runner`), and `bundled_catalog()` filters
its rows once, through `catalog_visible`.

Fixed on 2026-10-03: the non-floating navigation branch draws its band and
pill without the `android` conditions it could never meet. `apps::is_linked`
stays: since #309 the system agent's grants call it to tell which native
apps this build links (`native_system_tools` in
`crates/shell/src/system_chat/grants.rs`).

- [x] **CAL-01 — P2: Host the Calendar module from mobile PR #11.**

Everything else in PR #11 (`feat/calendar-module`) is present; Calendar
Expand Down
Loading