Repository navigation
Close HUB-05: drop dead android navigation checks - #270
Merged
Merged
Conversation
guofoo
force-pushed
the
fix/hub-05-cleanups
branch
from
October 2, 2026 18:32
ed790e9 to
55771cc
Compare
mobile_surface's non-floating navigation branch runs only where mobile_navigation::ENABLED is false, which is never on Android, so its `if android` band height and `!(android && insets.bottom > 0)` pill condition could not hold; the band is `bottom` and the pill always draws. apps::is_linked, the other HUB-05 point, is no longer test-only: since #309 native_system_tools calls it, so it stays. BACKLOG.md says so.
guofoo
force-pushed
the
fix/hub-05-cleanups
branch
from
October 3, 2026 07:47
55771cc to
c80a384
Compare
guofoo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves the two points left in
phone/BACKLOG.mdHUB-05 (P3, small cleanups after the App Hub merge):Dead
androidconditions incrates/shell/src/mobile_surface.rsare removed. The non-floating navigation branch runs only wheremobile_navigation::ENABLEDis false, and it'scfg!(any(target_os = "android", target_env = "ohos")), so that branch never runs on Android.if android {…taller band…} else {bottom}is nowbottom.else if !(android && phone.insets.bottom > 0.0)is nowelse.Nothing changes on any target. The
androidbinding is still used above for the status bar.apps::is_linkedstays. The backlog listed it as test-only. Since Makepad's apps as native apps: Calculator, Clock, Notes, Reminders and Weather with their own agents; Task as a process app #309,native_system_tools(crates/shell/src/system_chat/grants.rs) calls it to tell which native apps this build links. An earlier version of this PR removed it; that would no longer build onmain.The HUB-05 entry is marked done, and says why
is_linkedstays.Checks
Rebased on
main3afb9720(2026-10-03).tools/ci-local.sh --only desktop,phone,appsonc80a3849(clean tree): PASSED, 33 of 33 steps, none skipped, 27m09s, Darwin arm64. Theapps.ymljobs GitHub runs onubuntu-latestran on macOS here.