Fix Numba workqueue abort in feature streams - #184
Merged
Conversation
Run pooled Numba kernels as serial GIL-free code and order marker callbacks that retain inner parallelism. Add forced-workqueue coverage for RNA feature statistics and marker ranking.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Impact
Public signatures and persisted artifacts are unchanged. RNA feature summaries and rank marker searches complete safely with multiple Scarf workers under the workqueue backend.
Performance concern
Default matrix layouts can yield only one outer stream task. In that case, the newly serial kernels cannot use the full worker budget. This should be resolved before merge if preserving OpenMP performance is required.