Repository navigation
fix: gate agentless WaitForBuilds job on a mapped job variable - #87
Merged
Merged
Conversation
dependencies.RunRenovate.outputs[...] referenced directly in the agentless (pool: server) job condition was unreliable: build 12441 ran the Delay task even though the schedule name didn't match and the output variable resolved to 'False'. Map the output into a job-level variable first (same pattern MergePRs already uses) so condition evaluation reads a plain variables[] lookup instead. Also fixes $false interpolating to 'False' (capital) instead of 'false' when the output variable is initialized. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
3 tasks
NickGraham101
added a commit
that referenced
this pull request
Oct 2, 2026
PR #87/#88's fixes to the WaitForBuilds gate didn't work: build 12586 (Weekly Redeployment, both manual params false) still ran the Delay task. Isolated with the pipeline preview API against a scratch branch: ${{ and(parameters.RunRenovateManually, parameters.RunMergePRManually) }} compiled to True even with both params false, and and(param, true) compiled True regardless of the param's value -- the ADO expression engine isn't treating a boolean-typed parameter as boolean when it's an argument to and(), only when it's the sole value of a ${{ }} block. Wrapping each operand as eq(parameters.X, true) forces a real boolean comparison before and() sees it. Verified all four combinations (false/false, true/true, true/false, false/true) compile correctly via the preview API. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
renovate-run.yml'sWaitForBuildsjob (pool: server, agentless) referenceddependencies.RunRenovate.outputs['CheckScheduleName.RunRenovate']directly inline in itscondition:. Confirmed via build 12441 that this resolved incorrectly on a scheduled run — the Delay task ran even though the schedule name didn't match and the source output variable was'False'. Fix: map the output into a job-levelvariables:block first (same patternMergePRsalready uses at line 74) so the condition reads a plainvariables['RunRenovate']instead."$false"interpolating to'False'(capital) instead of'false'when the output variable is initialized inCheckScheduleName.Test plan
gandt-agentpipeline on schedule whereScheduleNamedoesn't match — confirmRunRenovate,WaitForBuilds,MergePRsall skip.ScheduleNamematches — confirm full chain runs (Renovate → Delay → Merge).RunRenovateManually/RunMergePRManually— confirm existing manual-run behavior unchanged.🤖 Generated with Claude Code