Repository navigation
fix: also gate the WaitForBuilds Delay task with a step condition - #88
Merged
Merged
Conversation
The job-level condition on the agentless WaitForBuilds job has never skipped it (builds 12313, 12361, 12441, 12508 all ran the 2h Delay on non-matching schedules) even though the mapped RunRenovate job variable resolved to 'false'. Repeat the condition on the Delay step so the wait is skipped when Renovate did not run. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
NickGraham101
added a commit
that referenced
this pull request
Oct 2, 2026
PR #87/#88's fixes to the WaitForBuilds gate didn't work: build 12586 (Weekly Redeployment, both manual params false) still ran the Delay task. Isolated with the pipeline preview API against a scratch branch: ${{ and(parameters.RunRenovateManually, parameters.RunMergePRManually) }} compiled to True even with both params false, and and(param, true) compiled True regardless of the param's value -- the ADO expression engine isn't treating a boolean-typed parameter as boolean when it's an argument to and(), only when it's the sole value of a ${{ }} block. Wrapping each operand as eq(parameters.X, true) forces a real boolean comparison before and() sees it. Verified all four combinations (false/false, true/true, true/false, false/true) compile correctly via the preview API. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RunRenovateinto a job variable, but the agentlessWaitForBuildsjob still ran its 2h Delay on non-matching schedules. The prepare log showsRunRenovate: Result: 'false', so the job condition should be False, yet the job ran.condition:on theDelay@1task, so the wait is skipped even if the job itself starts.Test plan
skipped.MergeDelayMinutes, then MergePRs runs.RunMergePRManually=trueonly should also skip the Delay.🤖 Generated with Claude Code