test(gate): coverage-gate self-test carries its own timeout - #42
Merged
Merged
Conversation
test_gate_fails_when_a_new_route_is_untested scans every test file twice: 26 s locally, and on 2026-09-23 it crossed the 60 s unit ceiling under --cov on the python 3.13 CI lane (3.12 passed; green on rerun; PR #41 run 35850516033). pyproject.toml already states the rule: a module whose honest cost sits near the ceiling carries an explicit pytest.mark.timeout rather than flaking against the global bound. 180 s, module-level, reason recorded in the file.
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The scoped timeout change addresses CI runtime failures without altering gate behavior.
Review effort: Lite
Findings: None
What changed in this PR
Adds a module-level 180-second timeout to the coverage-gate self-test, with documented runtime rationale and no gate logic changes.
Changes:
- Applies
pytest.mark.timeout(180). - Documents measured runtime and CI timeout context.
| File | Description |
|---|---|
packages/studyloop/tests/test_e2e_coverage_gate_selftest.py |
Adds the documented module timeout. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One line: the coverage-gate self-test module carries
pytest.mark.timeout(180).test_gate_fails_when_a_new_route_is_untestedscans every test file twice (route test + full-stack test): 26 s on a laptop, and on 2026-09-23 it crossed the 60 s unit ceiling under--covon the python 3.13 lane of PR #41 (3.12 passed; green on rerun).pyproject.tomlalready states the rule for modules near the ceiling; this applies it, with the measurement recorded in the file. Not a change to the gate itself.