Skip to content

e2e: the fullscreen bar case waits for the player's video (race, not a player bug) #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Nawid3333 merged 1 commit into from
Oct 10, 2026
Merged

e2e: the fullscreen bar case waits for the player's video (race, not a player bug) #425

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions tests/e2e/classic-specs/content-overlays.e2e.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -572,8 +572,13 @@ describe('A site\'s overlays around an in-page player', function() {
return frame.isExisting();
}, {timeout: 15000, timeoutMsg: 'the player never came up'});
await browser.switchFrame(frame);
await browser.waitUntil(() => browser.execute(() => !!window.fastStream?.interfaceController),
{timeout: 15000, timeoutMsg: 'the player never started'});
// Its video loaded, not just the interface there: setting the source resets the player
// (big play button back, not playing), and that could come after the playing state set
// below, and the bar rightly stayed up (2026-10-10: main and #422 on CI, once in six runs
// locally; the case's report read bigPlay true, playing false).
await browser.waitUntil(() => browser.execute(() => !!window.fastStream?.source &&
window.fastStream.player?.getVideo?.()?.readyState >= 1),
{timeout: 15000, timeoutMsg: 'the player never loaded its video'});
await browser.execute(() => {
window.fastStream.interfaceController.hideBigPlayButton();
window.fastStream.state.playing = true;
Expand Down
Loading