Repository navigation
e2e: the fullscreen bar case waits for the player's video (race, not a player bug) - #425
Merged
Merged
Conversation
…lays at being played The source's setup resets the player (big play button back, not playing). On CI's slower runners, and once in six local runs, that reset came after the case set its playing state, and the bar rightly stayed up (its report: bigPlay true, playing false). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The content-overlays case "hides the player's bar after fullscreen was left and entered again with its button" failed on main (Windows, Firefox 157) and on #422 (Firefox 158 beta), both times on retry too. The report it now prints showed why:
bigPlay: true, playing: false.A race in the test, not a player bug. The case marks the player as playing as soon as its interface exists. The source arrives later (a message from the background), and setting it resets the player: big play button back, not playing. When that reset came after the case's playing state, the bar rightly stayed up. Logged locally: once the case acted while the player was still being built (source set, player not yet); and the unchanged case failed once in six local runs on Firefox 157 with exactly CI's report. In real use playback starts after that setup, so the bar hides as it should.
The case now waits until the player's video has loaded (
sourceset,readyState >= 1) before it plays at being played.Checks: the case 8 of 8 on Firefox 157 (no retries); the whole spec 8 passing on Firefox 158.0b5 (unpacked locally, not installed).
🤖 Generated with Claude Code