Skip to content

fix(site): link the Korean install section by an ASCII id - #32

Merged
NaNIsaac merged 1 commit into
mainfrom
fix/site-ko-anchor
Oct 23, 2026
Merged

NaNIsaac merged 1 commit into
mainfrom
fix/site-ko-anchor

Conversation

@NaNIsaac

Copy link
Copy Markdown
Owner

Tier: low

  • One Korean heading gets an explicit id (## 설치 {#install}) and the link to it is updated.
  • New site/scripts/check_links.py runs after the build in docs.yml and fails on broken internal links or anchors.
  • No change to page text, the CLI, or the English pages.

Fixes #31.

Validation

  • cd site && npm ci && npm run build passes.
  • python site/scripts/check_links.py: 27 pages, 0 broken links (before the fix it reported ko/installation.html: /codigest/ko/rust-port#설치 has no such anchor).
  • ruff check and ruff format --check pass on the new script.

Independent of #29; the two touch different lines of docs.yml. Once #29 merges, the link check also runs on pull requests.

VitePress decomposes Hangul ids to NFD, so the NFC link to rust-port#설치
never matched. Use {#install} like the English page and check links and
anchors of the built site in the docs workflow.

Fixes #31
@NaNIsaac
NaNIsaac merged commit 56812a0 into main Oct 23, 2026
3 checks passed
@NaNIsaac
NaNIsaac deleted the fix/site-ko-anchor branch October 23, 2026 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

site: Korean in-page link to rust-port#설치 does not reach the heading

1 participant