Repository navigation
test(gui): wait on the listing in the arrow-key tests - #26
Merged
Merged
Conversation
This was referenced Oct 22, 2026
Owner
Author
|
Cause of the ubuntu failure: the arrow-key test waited only for 7c2204f waits until the rows are in sorted order and picks the start row by path. Test-only change. CI on this commit: ubuntu, windows, ruff, examples and readme (3 OS) all pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tier: low
tests/test_gui.py: the two arrow-key tests wait on the condition with thewait_untilfixture instead of a fixed 2 s poll.Refs #24. This replaces #25, which was closed when #22 was merged and its base branch deleted; the commit is the same, rebased onto main.
test_arrow_keys_move_the_previewandtest_arrow_keys_do_nothing_without_a_preview_tabpolledQFileSystemModelfor 2 s; under full CPU load the folder was not populated in time (7 of 10 whole-file runs failed there). They now wait up to 10 s for the row count and, in the first, for the preview to move.Load result, measured on the pre-merge head of #25 (same change): whole
tests/test_gui.py, 12 busy-loop processes, 10 runs: 7 passed, 3 failed, all three intest_filter_narrows_the_listing, not in the arrow-key tests (the arrow-key tests passed in all 7 runs that reached them). The filter failures are discussed in #14. Not repeated for this rebased branch.Checked:
ruff checkpasses; on an idle machine the wholetests/test_gui.pypasses (33 tests).conventions.py check QoraDFXMreads the main checkout; nothing it checks changes here.