Repository navigation
docs: remove Korean, numbered and banner comments - #33
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tier: low.
Comments and docstrings only. Comments are English and say why; banners, numbered step comments and Korean comments are removed (BACKLOG rule 27).
Checker (
conventions.pycomment_findings, run with Python 3.14, no unparsed files):The 10 banners that remain are all in
tests/test_gui.py, which open PR #26 (fix/gui-arrow-key-waits) also changes, so it is skipped here. PR #26 covers them; they can be removed after it merges.Skipped because open PRs touch them:
tests/test_gui.py(#26);CHANGELOG.mdandpyproject.toml(#31, not edited anyway). Other unmerged remote branches were checked: all except #26 and #31 belong to merged PRs (squash merges), andfix/gui-wait-for-modelis a closed PR (#25,tests/conftest.pyandtests/test_gui.py), so only thetest_gui.pyskip applies.Flagged comments handled (103 lines outside the skipped file): 87 deleted, 16 kept as short English comments or docstrings (rewritten or translated). Deleted: 72 banners, 9 numbered steps, 6 Korean comments that restated the next line or were change notes (including
# <--- 'msc.camera' 수정!). Kept: reasons and constraints (for example why the check-mark icon is written to a temp PNG, which side measures and which draws the ring profile) and short docstrings.AST identical (24 files). Python AST dump with docstrings stripped, taken before and after, is identical for every changed .py file (24 of 45 tracked .py files changed; the other 21 are untouched). Only .py files changed; every diff line is a comment, docstring or blank line.
Docstrings: nothing reads
__doc__/inspect, and the CLI parser descriptions were not touched, so no help text changed.Korean strings left alone (UI, log and status text, outside the rule): in
src/qoradfxm/core/ops.py,gui/control_dock.py,gui/documents.py,gui/file_dock.py,gui/image_view.py,gui/main_window.py,gui/models.py,gui/pipeline.py,gui/results_table.py,gui/results_window.py,gui/ribbon.py,gui/ring_panel.py,gui/settings_dialog.py,gui/widgets.py.Local checks run:
ruff@0.17.1 checkandruff@0.17.1 format --check(the versions from.github/workflows/lint.yml), the comment checker, and the AST equality script. Left to CI: pytest (uv.locklists cupy and nvidia packages, so I did not runuv sync); a comment-only change cannot alter test results given the AST equality.