[elyasmnvidian]

This PR adds the shared routing-log reader for the desktop app.

rollup::Reader reads newly completed lines from routing.jsonl and totals usage for today and the seven local calendar days ending today. It keeps answer calls separate from classifier calls. It starts over when the log is replaced or truncated. An invalid complete record returns an error instead of showing incomplete usage.

The reader and record types live in the desktop library so the graphical and terminal apps can share them. The basic window follows in #1137. Printed summaries and savings follow in #1086.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Source mode: Auto
• Repository: NVIDIA-NeMo/Switchyard
• Branch: emehtabuddin/s04-desktop-usage-rollup
• File: .coderabbit.yaml
• Commit: 4ef061b
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Enterprise
• Run ID: ed361eec-5ce4-4217-a4d0-015316edd460

📥 Commits

Reviewing files that changed from the base of the PR and between b2e9386 and 4ef061b.

📒 Files selected for processing: 5

• crates/switchyard-desktop/Cargo.toml
• crates/switchyard-desktop/src/history.rs
• crates/switchyard-desktop/src/main.rs
• crates/switchyard-desktop/src/rollup.rs
• crates/switchyard-desktop/src/summary.rs

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

Walkthrough

The desktop package adds routing-log usage aggregation, summary formatting, and a command-line app. The app supports help, TOML validation, and printing a summary using configured settings, current usage, and server status.

Changes

Desktop usage summary

Layer / File(s)	Summary
Log entry and usage aggregation crates/switchyard-desktop/src/history.rs, crates/switchyard-desktop/src/rollup.rs	Adds a serializable routing-log entry type and aggregation for token, cost, and request totals. The reader handles appended and partial records, file truncation or replacement, and period totals. Tests cover token accounting and reader behavior.
Summary formatting crates/switchyard-desktop/src/summary.rs	Formats server status, period totals, weekly model shares, and incomplete-cost or uncounted-answer indicators.
Command-line flow crates/switchyard-desktop/src/main.rs, crates/switchyard-desktop/Cargo.toml	Adds help, print, and TOML-validation options. The app loads settings, reads usage, probes the configured server, and prints summary rows. The package selects its default executable.

Priority: ➖ Normal

Estimated code review effort: 3 (Moderate) | ~25 minutes

Merge Risk: ⚪ Minimal · up to 4ef06

The usage summary appears ready to merge after normal checks; no actionable issue was established in the current changes.

Pre-merge checks: 5

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title "feat(desktop): aggregate routing logs into daily and weekly token rollups" matches the main change. The PR adds rollup.rs, which aggregates routing-log records into daily, weekly, and all-t…
Docstring Coverage		Docstring coverage is 83.33% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 24 functions across 4 files. (1 skipped: 1 …
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Title check

Explanation

The title "feat(desktop): aggregate routing logs into daily and weekly token rollups" matches the main change. The PR adds rollup.rs, which aggregates routing-log records into daily, weekly, and all-time totals, and the summary.rs and main.rs files that display those totals. The title is concise and specific, and it names the primary feature. The title follows a conventional-commit style and does not mention unrelated files or changes.

Full details: Docstring Coverage

Explanation

Docstring coverage is 83.33% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 24 functions across 4 files. (1 skipped: 1 unsupported.)

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{A rabbit checks the log at night
Counts tokens by the lantern light
Seven days roll into view
Costs and routes are tallied too
The desktop prints a summary, neat}

_{Comment @coderabbitai help to get the list of available commands.}

[elyasmnvidian]

@coderabbitai full review

I added documentation for the rollup and summary helpers and updated the summary to show known spending when some calls have no recorded cost. Please review the current head and rerun the docstring coverage check.

[coderabbitai]

✅ Action performed

Full review finished.