Repository navigation
Port QEPro to ophyd-async and extract plans - #22
Open
Thomas Hopkins (thopkins32) wants to merge 3 commits into
Open
Thomas Hopkins (thopkins32) wants to merge 3 commits into
Thomas Hopkins (thopkins32) wants to merge 3 commits into
Conversation
Assisted-by: oh-my-pi:gpt-5.6-terra
Copilot started reviewing on behalf of
Thomas Hopkins (thopkins32)
September 30, 2026 21:38
View session
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The configuration plan ignores requests to disable electric dark correction.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Ports QEPro support to ophyd-async and adds reusable Bluesky configuration and acquisition plans.
Changes:
- Adds asynchronous QEPro/TEC devices with deterministic mock behavior.
- Adds QEPro configuration, frame-capture, and temperature plans.
- Adds behavioral tests and removes the obsolete PyEPICS development dependency.
| File | Description |
|---|---|
src/xpd_tools/detectors/qepro.py |
Implements QEPro devices and mocks. |
src/xpd_tools/detectors/__init__.py |
Exports QEPro classes. |
src/xpd_tools/qepro_plans.py |
Adds reusable QEPro plans. |
tests/detectors/test_qepro.py |
Tests device behavior and PV mappings. |
tests/test_qepro_plans.py |
Tests QEPro plans. |
pyproject.toml |
Removes PyEPICS from development dependencies. |
uv.lock |
Updates the resolved dependency set. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Copilot started reviewing on behalf of
Thomas Hopkins (thopkins32)
September 30, 2026 21:41
View session
Copilot started reviewing on behalf of
Thomas Hopkins (thopkins32)
September 30, 2026 21:44
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Assisted-by: oh-my-pi:gpt-5.6-terra
Summary
QEProdriver with an ophyd-asyncQEPro/QEProTECimplementation using declarative EPICS signals.QEProPV contract, raw feature-bit API, async TEC setpoint completion, and acquisition completion on theCOLLECT_RBVfalling edge.QEProMockbehavior for local tests, including completed collection cycles without wall-clock sleeps.QEProas a one-shotStandardReadablewith structuraltrigger()semantics:AsyncStatusStandardDetector/ fly / asset-provider lifecycle was introducedQEProfields:x_axis,output,sample,dark,reference,spectrum_type,integration_time,num_spectra, andbuff_capacity.QEPro-only plan primitives:configure_qepro,take_qepro_dark_frame,take_qepro_reference_frame, andset_qepro_temperature.surfaces, frame restoration, and fresh post-trigger spectrum reads.
Motivation / Context
Will be helpful for testing acquisition workflows offline for the Blop optimization described in #14