Repository navigation
feat: new user settings preview section #357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,93 @@ | ||
| using System.Text.Json.Nodes; | ||
| using System.Text.Json.Serialization; | ||
|
|
||
| namespace Moonfin.Server.Models; | ||
|
|
||
| /// <summary> | ||
| /// What one user gets on one device type, setting by setting, for the admin preview. | ||
| /// </summary> | ||
| public class SettingsExplanation | ||
| { | ||
| [JsonPropertyName("profile")] | ||
| public string Profile { get; set; } = string.Empty; | ||
|
|
||
| /// <summary>False when the user never synced, so everything comes from the defaults.</summary> | ||
| [JsonPropertyName("hasSettingsFile")] | ||
| public bool HasSettingsFile { get; set; } | ||
|
|
||
| [JsonPropertyName("lastUpdated")] | ||
| public long? LastUpdated { get; set; } | ||
|
|
||
| [JsonPropertyName("lastUpdatedBy")] | ||
| public string? LastUpdatedBy { get; set; } | ||
|
|
||
| [JsonPropertyName("fields")] | ||
| public List<SettingExplanation> Fields { get; set; } = new(); | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// One setting: the value the user gets, the layer it comes from, and what each layer holds. | ||
| /// </summary> | ||
| public class SettingExplanation | ||
| { | ||
| [JsonPropertyName("name")] | ||
| public string Name { get; set; } = string.Empty; | ||
|
|
||
| /// <summary>device, global, default (the admin defaults) or none (the app's own default).</summary> | ||
| [JsonPropertyName("source")] | ||
| public string Source { get; set; } = "none"; | ||
|
|
||
| [JsonPropertyName("effective")] | ||
| public JsonNode? Effective { get; set; } | ||
|
|
||
| [JsonPropertyName("device")] | ||
| public JsonNode? Device { get; set; } | ||
|
|
||
| [JsonPropertyName("global")] | ||
| public JsonNode? Global { get; set; } | ||
|
|
||
| [JsonPropertyName("default")] | ||
| public JsonNode? Default { get; set; } | ||
|
|
||
| /// <summary>The device value only repeats what global or the defaults would give.</summary> | ||
| [JsonPropertyName("deviceRedundant")] | ||
| public bool DeviceRedundant { get; set; } | ||
|
|
||
| /// <summary>The global value only repeats the admin default.</summary> | ||
| [JsonPropertyName("globalRedundant")] | ||
| public bool GlobalRedundant { get; set; } | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// How many settings one user has stored in each profile, for the admin overview. | ||
| /// </summary> | ||
| public class SettingsOverviewEntry | ||
| { | ||
| [JsonPropertyName("userId")] | ||
| public Guid UserId { get; set; } | ||
|
|
||
| [JsonPropertyName("hasSettingsFile")] | ||
| public bool HasSettingsFile { get; set; } | ||
|
|
||
| [JsonPropertyName("lastUpdated")] | ||
| public long? LastUpdated { get; set; } | ||
|
|
||
| [JsonPropertyName("lastUpdatedBy")] | ||
| public string? LastUpdatedBy { get; set; } | ||
|
|
||
| [JsonPropertyName("desktop")] | ||
| public int Desktop { get; set; } | ||
|
|
||
| [JsonPropertyName("mobile")] | ||
| public int Mobile { get; set; } | ||
|
|
||
| [JsonPropertyName("tv")] | ||
| public int Tv { get; set; } | ||
|
|
||
| [JsonPropertyName("global")] | ||
| public int Global { get; set; } | ||
|
|
||
| /// <summary>How many stored values only repeat what the layers below give.</summary> | ||
| [JsonPropertyName("repeated")] | ||
| public int Repeated { get; set; } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Explain why this settings change is Jellyfin-only.
This PR changes the Jellyfin port only. “Emby was not tested” does not explain whether Emby is intentionally out of scope or why. Add a short scope note and reason to the PR description. That explanation satisfies the cross-port review requirement; an Emby port is not required by this contract.
This is a scope-documentation issue, not evidence of an Emby runtime regression.