fix(tui): restore chat after transient layout shrink - #333
Merged
Merged
Conversation
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Closing
/themewith Escape could leave a blank region above the conversation. The same rendering rule affected settings and history pickers, panel replacement, completion menus, image previews, multiline drafts, task/Goal summaries, queued messages and asynchronously disappearing notices. Earlier fixes in #328 and #331 covered only selected close paths.Classify shrink from the rendered layout. ChatLayout records the heights of its transient sections, SurfaceHost includes the active feature, and MainScreen preserves background scroll position only while every root declares an unchanged layout key and no overlay was present. Changed or unknown layouts restore exposed chat rows; short documents still update in place. Remove the completion-specific callback and full-viewport close exception. Update capability documentation and the engine change ledger.
Validation
/theme→ Escape failed before the fix: the physical viewport contained blank rows where the current conversation should be visible. The regression passes with the unified rule./theme,/settings, prompt-history search, image-preview dismissal, multiline draft clearing and the existing/usage/autocomplete cases. Repeated expansion and shrink cover eight transient layout sections under xterm and an ED 2 clear-to-scrollback model, with exact viewport and unique-history assertions. Overlay hide/setHidden, mixed roots, short-document clearing and background scroll preservation are covered.pnpm verifyona42d54d7672803aacdcdda25ceb3defb446bf555: PASS, all 14 applicable macOS gates. Typecheck andgit diff --checkalso passed.Publication and contribution checks
Maintainer handoff
Publication scope or license changes: none.
Shared-source port: pending maintainer review after this public PR.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.