test(tui): cover permission picker table restoration - #353
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Closing the permission mode picker on the older renderer could insert eight blank rows into an already-rendered Markdown table. The runtime fix is already merged in #333. Add a focused regression for this exact symptom using the real permission picker, inline panel host, ChatLayout, TranscriptView and MainScreen renderer; no additional runtime changes are needed.
Cover Enter and Escape at 60 and 100 columns under xterm and an ED 2 clear-to-scrollback host model. Assert exact restoration of the original buffer, contiguous table rows, cursor placement, repeated redraws and subsequent table growth.
Validation
pnpm verifyon clean commit2552289f24f2dd79b936b2e6ce48590484c1e803: PASS, all 15 applicable macOS gates. The capability gate passed 4,600 tests (14 skipped).Publication and contribution checks
Maintainer handoff
Publication scope or license changes: none.
Shared-source port: not needed for runtime behavior; optional regression-test port after review.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.