fix(tui): restore chat viewport after autocomplete shrinks - #331
Merged
Merged
Conversation
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Typing
/and then pressing Escape in a long regular-mode conversation could move the visible chat downward, leaving the completion menu's former rows blank at the top. Filtering or accepting candidates could cause the same problem. This follows up on #328, which covered full-viewport interaction panels.Report completion layout changes from the editor and restore the exposed chat rows when the menu shrinks. Reconstruct history only when scrolled rows must return to the viewport; short documents retain incremental rendering. Ordinary activity shrink keeps its existing native-scroll protection. Update the TUI capability documentation and engine change ledger.
Validation
/→ Escape regression failed with the first nonblank row moving from index 2 to 11; it passes after the repair.pnpm typecheckandgit diff --check: PASS.pnpm verifyon55d68c874ec7dada29cb8cd47a6a34413ee42206: PASS, all 14 applicable gates on macOS.Publication and contribution checks
Maintainer handoff
Publication scope or license changes: none.
Shared-source port: pending maintainer review after this public PR.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.