Skip to content

EXP-4396: fix DSFinV-K cash point closing error field deserialization (38.1.1) #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abdallahbeshi merged 4 commits into from
Jun 26, 2026
Merged

EXP-4396: fix DSFinV-K cash point closing error field deserialization (38.1.1) #323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6eaefbb
EXP-4396: fix DSFinV-K cash point closing error field deserialization…
andresgrobastrigo Jun 26, 2026
ff5710d
EXP-4396: concatenate code and message in DSFinV-K closing error
andresgrobastrigo Jun 26, 2026
e982ce8
EXP-4396: simplify DSFinV-K closing error mapping
andresgrobastrigo Jun 26, 2026
2f17cbe
EXP-4396: include all error fields in DSFinV-K closing error mapping
andresgrobastrigo Jun 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions ...ly/Mews.Fiscalizations.Fiskaly/DTOs/DSFinVK/CashPointClosings/CashPointClosingResponse.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,22 @@ internal sealed class CashPointClosingResponse

[JsonPropertyName("error")]
[JsonIgnore(Condition = JsonIgnoreCondition.WhenWritingNull)]
public CashPointClosingError Error { get; init; }
}

internal sealed class CashPointClosingError
{
[JsonPropertyName("status_code")]
public int? StatusCode { get; init; }

[JsonPropertyName("error")]
public string Error { get; init; }

[JsonPropertyName("code")]
public string Code { get; init; }

[JsonPropertyName("message")]
public string Message { get; init; }
}

internal enum CashPointClosingState
Expand Down
4 changes: 3 additions & 1 deletion ...y/Mews.Fiscalizations.Fiskaly/Mappers/DSFinVK/CashPointClosings/CashPointClosingMapper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,9 @@ public static CashPointClosingResult MapResponse(this CashPointClosingResponseDt
ClientId: response.ClientId,
CashPointClosingExportId: response.CashPointClosingExportId,
State: MapState(response.State),
Error: response.Error
Error: response.Error != null
? string.Join(" ", new[] { response.Error.StatusCode?.ToString(), response.Error.Error, response.Error.Code, response.Error.Message }.Where(s => s != null))
: null
);
}

Expand Down
2 changes: 1 addition & 1 deletion src/Fiskaly/Mews.Fiscalizations.Fiskaly/Mews.Fiscalizations.Fiskaly.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
<RepositoryUrl>https://github.com/MewsSystems/fiscalizations</RepositoryUrl>
<Icon>https://raw.githubusercontent.com/msigut/eet/master/receipt.png</Icon>
<GeneratePackageOnBuild>true</GeneratePackageOnBuild>
<PackageVersion>2.5.0</PackageVersion>
<PackageVersion>2.5.1</PackageVersion>
<LangVersion>12</LangVersion>
<ImplicitUsings>true</ImplicitUsings>
</PropertyGroup>
Expand Down
2 changes: 1 addition & 1 deletion src/Mews.Fiscalizations.All/Mews.Fiscalizations.All.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
<RepositoryUrl>https://github.com/MewsSystems/fiscalizations</RepositoryUrl>
<Icon>https://raw.githubusercontent.com/msigut/eet/master/receipt.png</Icon>
<GeneratePackageOnBuild>true</GeneratePackageOnBuild>
<PackageVersion>38.1.0</PackageVersion>
<PackageVersion>38.1.1</PackageVersion>
<LangVersion>12</LangVersion>
<ImplicitUsings>true</ImplicitUsings>
<TargetsForTfmSpecificBuildOutput>$(TargetsForTfmSpecificBuildOutput);CopyProjectReferencesToPackage</TargetsForTfmSpecificBuildOutput>
Expand Down
Loading