EXP-4396: fix DSFinV-K cash point closing error field deserialization (38.1.1)

[andresgrobastrigo]

What

Fixes a JsonException thrown by DsfinvkClosingSynchronizerJob when Fiskaly returns a cash point closing in ERROR state.

Fiskaly API v1.27.6 (2026-06-16) started setting closings with incorrect use of SLAVE_WITHOUT_TSS cash registers to ERROR state. In that case the 200 response body includes an error object ({ code, message }), but CashPointClosingResponse had public string Error — causing the deserializer to throw at $.error.

Changes

• CashPointClosingResponse — change Error from string to a new CashPointClosingError DTO ({ Code, Message }).
• CashPointClosingMapper — map error object to string using Error?.Message ?? Error?.Code, preserving the public CashPointClosingResult.Error: string API contract.
• Versions — Fiskaly 2.5.0 → 2.5.1, All 38.1.0 → 38.1.1.

Notes

DsfinvkErrorResponse (used for HTTP 4xx/5xx) keeps error: string — that is correct per the Fiskaly spec (HTTP error responses use a plain string like "Bad Request").

🤖 Generated with Claude Code

[moxly]

✅ Review posted. View review · run

[moxly]

The pull request was updated while this review was being prepared, so it is posted as a comment rather than a formal review.

Risk Assessment

Score: 2/10 — low

Targeted hotfix for an external API contract change with no logic errors, no API surface breakage, and correct null-safety in the mapping. The only minor gap is the absent PR template checklist (no test file in the diff).

Review Summary

APPROVE — 0 findings. Clean fix.

The PR template's Checklist section (type of change, breaking-change flag, test coverage) was not included in the PR body. The "Tests included" item is the most relevant omission: no unit test was added to cover the new CashPointClosingError deserialization path or the Message ?? Code fallback logic. Given this is a hotfix driven by an upstream API change and the mapping logic is straightforward, this is a minor gap rather than a blocker — but a regression test for the ERROR state response would make future Fiskaly spec changes easier to catch.