refactor(tron-wallet-snap): assert supported networks at handler boundaries instead of casting - #394
Closed
ulissesferreira wants to merge 7 commits into
Closed
ulissesferreira wants to merge 7 commits into
ulissesferreira wants to merge 7 commits into
Conversation
ulissesferreira
force-pushed
the
WPN-2217-remove-scope-network-forced-casts
branch
2 times, most recently
from
September 30, 2026 15:51
0ddf3d2 to
995dd3d
Compare
ulissesferreira
force-pushed
the
WPN-2217-remove-scope-network-forced-casts
branch
from
September 30, 2026 15:56
995dd3d to
08849c2
Compare
ulissesferreira
added this pull request to stack #395
September 30, 2026 16:06
ulissesferreira
force-pushed
the
WPN-2217-remove-scope-network-forced-casts
branch
6 times, most recently
from
October 1, 2026 14:31
090e695 to
7a86d64
Compare
ulissesferreira
removed this pull request from stack #395
October 1, 2026 15:17
…daries instead of casting
- Assert supported networks where data enters the snap: manifest scopes, AssetsController assets, Token API filtering and TrackTransaction background event params. - Carry the validated `Network` type instead of re-casting: sign renderers take `TronWalletKeyringRequest`, send uses `asset.network`, staking and zero-balance assets use `getAssetNetwork`. - Add `TronKeyringAccount` with `scopes: Network[]` for stored accounts; it remains assignable to the emitted `KeyringAccount`. - Build CAIP asset types from `Network` instead of `TrxScope`. - Add a lint rule banning casts to `Network` or `TrxScope` in the Tron snap.
Per review, keep the root ESLint config untouched: the no-tron-network-casts rule block and the shared no-enums selector extraction are dropped.
…ues(Network) The config structs validate the clients' baseUrls as record(NetworkStruct, UrlStruct), so keys are guaranteed to be supported networks. Iterating Object.values(Network) keeps that typing end to end, removing the Object.entries key-widening that previously forced a runtime isSupportedNetwork guard (and, before this PR, an 'as Network' cast).
ulissesferreira
force-pushed
the
WPN-2217-remove-scope-network-forced-casts
branch
from
October 1, 2026 15:27
7a86d64 to
33731fa
Compare
|
ulissesferreira
commented
Oct 1, 2026
Contributor
Author
There was a problem hiding this comment.
When working locally on each Snap we should have narrowed types for certain locally stored things that we know are chain specific. Keyring accounts are a good example.
ulissesferreira
commented
Oct 1, 2026
Contributor
Author
There was a problem hiding this comment.
The previous code's direct access to baseUrl was nice but doesn't play well with typescript because network always gets casted as string.
ulissesferreira
commented
Oct 1, 2026
Contributor
Author
There was a problem hiding this comment.
The previous code's direct access to baseUrl was nice but doesn't play well with typescript because network always gets casted as string.
ulissesferreira
force-pushed
the
WPN-2217-remove-scope-network-forced-casts
branch
from
October 1, 2026 16:49
98a9bbe to
746f36f
Compare
Contributor
Author
|
Superseded by #402 — the branch was renamed to |
This was referenced Oct 1, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
The Tron Snap handled scopes and networks coming from untrusted boundaries (RPC request params, the Keyring API) with forced casts (
chainId as Network,scope as Network), silently accepting values the Snap does not control and indexingNetworks[...]with them.This PR replaces those casts with runtime assertions at the handler boundary, matching how other request fields are validated:
isNetwork(type guard) andassertNetwork(throwsInvalidParamsError) next toNetworkinconstants.ClientRequestHandler: the fourchainId as Networkcasts (onAmountInput,confirmSend,claimUnstakedTrx,claimTrxStakingRewards) now useassertNetwork(chainId).KeyringHandler.resolveAccountAddress: the extension-providedscopeis asserted instead of cast.Follow-up work (out of scope): collapse the remaining internally-consistent casts (
SendService,StakingService, asset mappers) and the config/manifest-derived casts by flowingNetworkdown from these boundaries.Ticket: WPN-2217
References
Based on the review thread in #388. This PR is intended to serve as the base that #388 builds on.
Checklist