refactor(tron-wallet-snap): guarantee local type consistency for networks - #403
Draft
ulissesferreira wants to merge 1 commit into
Draft
ulissesferreira wants to merge 1 commit into
ulissesferreira wants to merge 1 commit into
Conversation
Closed
3 of 4 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
The Tron Snap handled scopes and networks coming from untrusted boundaries (RPC request params, the Keyring API) with forced casts (
chainId as Network,scope as Network), silently accepting values the Snap does not control and indexingNetworks[...]with them.This PR replaces those casts with runtime assertions and type-safe helpers so the
Network, scope, and CAIP asset types stay consistent within the Snap:isNetwork(type guard) andassertNetwork(throwsInvalidParamsError) next toNetworkinconstants.parseTronCaipAssetTypeinutils/caip.tsto parse CAIP asset types into Tron scopes without casts.Object.values(Network)and asserts supported networks at handler boundaries.Supersedes #394 / #402 (branch renamed and scope reduced to the type-consistency changes only).
Ticket: WPN-2226
Checklist