Skip to content

docs(maintenance-pool): add rationale comment for single-recipient fee calculation in withdraw #434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rushikeshgarad2024-dev wants to merge 1 commit into
base: main
Choose a base branch
from
Open

docs(maintenance-pool): add rationale comment for single-recipient fee calculation in withdraw #434

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions contracts/maintenance-pool/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,8 @@ mod contract {

let fee_bps: u32 = mergefi_common::get_fee_bps::<DataKey>(&env)
.ok_or(Error::NotInitialized)?;
// Single-recipient fee calculation: maintenance-pool payouts target a single maintainer,
// so multi-recipient largest-remainder rounding (compute_split) is not required (issue #322).
let fee = amount
.checked_mul(fee_bps as i128)
.ok_or(Error::ArithmeticOverflow)?
Expand Down