Skip to content

feat(skills): show familiar cost and timing icons - #433

Open
Mat4m0 wants to merge 1 commit into
fix/map-overlay-closefrom
feat/skill-detail-icons
Open

feat(skills): show familiar cost and timing icons#433
Mat4m0 wants to merge 1 commit into
fix/map-overlay-closefrom
feat/skill-detail-icons

Conversation

@Mat4m0

@Mat4m0 Mat4m0 commented Sep 11, 2026

Copy link
Copy Markdown
Owner

Skill costs and timings were spread across large text blocks. Builds and Elite Skills now use the familiar energy, adrenaline, activation, recharge, sacrifice, and overcast icons in one compact row. Labels remain available to assistive technology and on hover; fractional timings, health percentages, and player-only restrictions are preserved.

Reuse the shared skill detail component and bundle the six original Guild Wars Wiki Tango PNGs locally. Include source attribution and the complete GFDL notice in the existing packaged notices file. Skill artwork and descriptions still come from the installed client.

This is the fourth layer of stack #432, based on #431. Character-specific filtering and compact map controls follow in #434.

Verification:

  • pnpm check and pnpm build passed on this layer.
  • Component tests cover icon labels, fractional seconds, percentages, zero values, and unavailable descriptions.
  • The existing catalogue browser test passed with the accessible recharge icon.
  • Browser exploration covered the shared presentation in both visual themes.

GitHub Application verification failed at the dependency audit, before app tests ran. The existing findings affect website dependencies sharp, js-yaml, and svgo. This PR does not change dependencies; full CI must pass before merge.

Prepared with Codex using the repository test harness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant