Migrate graders_manager.jsx GroupsTable, GradersTable, CriteriaTable to React Table V8#8014
Open
mrafie1 wants to merge 33 commits into
Open
Migrate graders_manager.jsx GroupsTable, GradersTable, CriteriaTable to React Table V8#8014mrafie1 wants to merge 33 commits into
mrafie1 wants to merge 33 commits into
Conversation
…Updated filter.jsx to account for new component
… migrate-GradersManager
Bumps [dayjs](https://github.com/iamkun/dayjs) from 1.11.13 to 1.11.21. - [Release notes](https://github.com/iamkun/dayjs/releases) - [Changelog](https://github.com/iamkun/dayjs/blob/dev/CHANGELOG.md) - [Commits](iamkun/dayjs@v1.11.13...v1.11.21) --- updated-dependencies: - dependency-name: dayjs dependency-version: 1.11.21 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [action_policy](https://github.com/palkan/action_policy) from 0.7.5 to 0.7.6. - [Release notes](https://github.com/palkan/action_policy/releases) - [Changelog](https://github.com/palkan/action_policy/blob/master/CHANGELOG.md) - [Commits](palkan/action_policy@v0.7.5...v0.7.6) --- updated-dependencies: - dependency-name: action_policy dependency-version: 0.7.6 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [dompurify](https://github.com/cure53/DOMPurify) from 3.4.0 to 3.4.9. - [Release notes](https://github.com/cure53/DOMPurify/releases) - [Commits](cure53/DOMPurify@3.4.0...3.4.9) --- updated-dependencies: - dependency-name: dompurify dependency-version: 3.4.9 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [playwright](https://github.com/microsoft/playwright-python) from 1.59.0 to 1.60.0. - [Release notes](https://github.com/microsoft/playwright-python/releases) - [Commits](microsoft/playwright-python@v1.59.0...v1.60.0) --- updated-dependencies: - dependency-name: playwright dependency-version: 1.60.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
updates: - [github.com/thibaudcolas/pre-commit-stylelint: v17.10.0 → v17.12.0](thibaudcolas/pre-commit-stylelint@v17.10.0...v17.12.0) - [github.com/rubocop/rubocop: v1.86.1 → v1.87.0](rubocop/rubocop@v1.86.1...v1.87.0) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Bumps the rjsf group with 2 updates: [@rjsf/core](https://github.com/rjsf-team/react-jsonschema-form) and [@rjsf/validator-ajv8](https://github.com/rjsf-team/react-jsonschema-form). Updates `@rjsf/core` from 6.5.2 to 6.6.1 - [Release notes](https://github.com/rjsf-team/react-jsonschema-form/releases) - [Changelog](https://github.com/rjsf-team/react-jsonschema-form/blob/main/CHANGELOG.md) - [Commits](rjsf-team/react-jsonschema-form@6.5.2...6.6.1) Updates `@rjsf/validator-ajv8` from 6.5.2 to 6.6.1 - [Release notes](https://github.com/rjsf-team/react-jsonschema-form/releases) - [Changelog](https://github.com/rjsf-team/react-jsonschema-form/blob/main/CHANGELOG.md) - [Commits](rjsf-team/react-jsonschema-form@6.5.2...6.6.1) --- updated-dependencies: - dependency-name: "@rjsf/core" dependency-version: 6.6.1 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: rjsf - dependency-name: "@rjsf/validator-ajv8" dependency-version: 6.6.1 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: rjsf ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [dompurify](https://github.com/cure53/DOMPurify) from 3.4.9 to 3.4.11. - [Release notes](https://github.com/cure53/DOMPurify/releases) - [Commits](cure53/DOMPurify@3.4.9...3.4.11) --- updated-dependencies: - dependency-name: dompurify dependency-version: 3.4.11 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.19.3 to 1.19.4. - [Release notes](https://github.com/sparklemotion/nokogiri/releases) - [Changelog](https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md) - [Commits](sparklemotion/nokogiri@v1.19.3...v1.19.4) --- updated-dependencies: - dependency-name: nokogiri dependency-version: 1.19.4 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…8011) Bumps [concurrent-ruby](https://github.com/ruby-concurrency/concurrent-ruby) from 1.3.6 to 1.3.7. - [Release notes](https://github.com/ruby-concurrency/concurrent-ruby/releases) - [Changelog](https://github.com/ruby-concurrency/concurrent-ruby/blob/master/CHANGELOG.md) - [Commits](ruby-concurrency/concurrent-ruby@v1.3.6...v1.3.7) --- updated-dependencies: - dependency-name: concurrent-ruby dependency-version: 1.3.7 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
9 tasks
9 tasks
Collaborator
Coverage Report for CI Build 27919617964Coverage decreased (-0.08%) to 90.186%Details
Uncovered Changes
Coverage Regressions6 previously-covered lines in 2 files lost coverage.
Coverage Stats💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
(Describe your changes here. Also describe the motivation for your changes: what problem do they solve, or how do they improve the application or codebase? If this pull request fixes an open issue, use a keyword to link this pull request to the issue.)
tablefolder to include case sensitive filtering along side searching:case_sensitive_search_filterfilter.jsxto allow this component to be displayed when filterVariant: "case-sensitive-text" is usedcase_sensitive_search_filter.jsxfile, I updated the structure of filterValuevalueattribute that contains the actual value to be filtered (Let me know if you want this name to be changed)caseSensitiveattribute which is a boolean with the default value offalse. This changes when the user toggles the caseSensitive checkbox.search_filter.jsxaria-label definitiondefaultSearchPlaceholderTextto take in optional parameterheadergetSelectedRows()andresetSelection()<Table>filterValue.filterValue, and filter based on case sensitivity iffilterValue.caseSensitiveis true.Screenshots of your changes (if applicable)
See [link](https://github.com//pull/8002)Associated documentation repository pull request (if applicable)
Type of Change
(Write an
Xor a brief description next to the type or types that best describe your changes.)Checklist
(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the
[ ]into a[x]in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)Before opening your pull request:
After opening your pull request:
Questions and Comments
(Include any questions or comments you have regarding your changes.)
About the criteria and section column of the
groupTable, the functionality works.Now the issue is that the spacing is a bit weird with tables that have showCoverage = true. The "graders" column data covers/overlaps the "coverage" column data. Only slightly adjusting the widths of the columns fixes the problem. Not sure how to approach this issue. I'll tinker a little bit with the minSize attributes of the column, but let me know if this is within scope of my task.
Images of issue:

Before slightly adjusting column widths using mouse pointer:
After:

In regard to Git, I had to close my previous pull request. Running Git Pull Upstream Master caused all of the previous changes made by other peers to be present in my PR, including line count and file changes. I ended up opening this PR, and the line updates/file changes reflect my actual work. However, the commits/contributors have carried over. I've asked some of the MarkUs people for help, and I've tried rebasing, but I'm still encountering this issue.