Migrate graders_manager.jsx to React Table V8#8002
Conversation
…Updated filter.jsx to account for new component
… migrate-GradersManager
Coverage Report for CI Build 27581324586Coverage decreased (-0.05%) to 90.162%Details
Uncovered Changes
Coverage Regressions4 previously-covered lines in 2 files lost coverage.
Coverage Stats💛 - Coveralls |
david-yz-liu
left a comment
There was a problem hiding this comment.
@mrafie1 nice work, I left a few inline comments. Also, please make sure to convert the criteria table in this view as well.
You don't need to worry about test coverage for textFilter.
|
|
||
| export const defaultSearchPlaceholderText = () => I18n.t("table.search"); | ||
|
|
||
| export default function CaseSensitiveSearchFilter({column, filterValue}) { |
There was a problem hiding this comment.
It's fine to duplicate the caseSensitiveTextFilter component for React table v6, but you need to fully duplicate the logic. In particular, there is no need to store "case sensitive" state in the parent component. Instead, column.setFilterValue should pass an object (keys filterValue, caseSensitive) which are then used by the corresponding filter. This plays the same role as the onChange handler in the existing component.
For more information see #7938.
Bumps [dayjs](https://github.com/iamkun/dayjs) from 1.11.13 to 1.11.21. - [Release notes](https://github.com/iamkun/dayjs/releases) - [Changelog](https://github.com/iamkun/dayjs/blob/dev/CHANGELOG.md) - [Commits](iamkun/dayjs@v1.11.13...v1.11.21) --- updated-dependencies: - dependency-name: dayjs dependency-version: 1.11.21 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [action_policy](https://github.com/palkan/action_policy) from 0.7.5 to 0.7.6. - [Release notes](https://github.com/palkan/action_policy/releases) - [Changelog](https://github.com/palkan/action_policy/blob/master/CHANGELOG.md) - [Commits](palkan/action_policy@v0.7.5...v0.7.6) --- updated-dependencies: - dependency-name: action_policy dependency-version: 0.7.6 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [dompurify](https://github.com/cure53/DOMPurify) from 3.4.0 to 3.4.9. - [Release notes](https://github.com/cure53/DOMPurify/releases) - [Commits](cure53/DOMPurify@3.4.0...3.4.9) --- updated-dependencies: - dependency-name: dompurify dependency-version: 3.4.9 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [playwright](https://github.com/microsoft/playwright-python) from 1.59.0 to 1.60.0. - [Release notes](https://github.com/microsoft/playwright-python/releases) - [Commits](microsoft/playwright-python@v1.59.0...v1.60.0) --- updated-dependencies: - dependency-name: playwright dependency-version: 1.60.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
updates: - [github.com/thibaudcolas/pre-commit-stylelint: v17.10.0 → v17.12.0](thibaudcolas/pre-commit-stylelint@v17.10.0...v17.12.0) - [github.com/rubocop/rubocop: v1.86.1 → v1.87.0](rubocop/rubocop@v1.86.1...v1.87.0) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Bumps the rjsf group with 2 updates: [@rjsf/core](https://github.com/rjsf-team/react-jsonschema-form) and [@rjsf/validator-ajv8](https://github.com/rjsf-team/react-jsonschema-form). Updates `@rjsf/core` from 6.5.2 to 6.6.1 - [Release notes](https://github.com/rjsf-team/react-jsonschema-form/releases) - [Changelog](https://github.com/rjsf-team/react-jsonschema-form/blob/main/CHANGELOG.md) - [Commits](rjsf-team/react-jsonschema-form@6.5.2...6.6.1) Updates `@rjsf/validator-ajv8` from 6.5.2 to 6.6.1 - [Release notes](https://github.com/rjsf-team/react-jsonschema-form/releases) - [Changelog](https://github.com/rjsf-team/react-jsonschema-form/blob/main/CHANGELOG.md) - [Commits](rjsf-team/react-jsonschema-form@6.5.2...6.6.1) --- updated-dependencies: - dependency-name: "@rjsf/core" dependency-version: 6.6.1 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: rjsf - dependency-name: "@rjsf/validator-ajv8" dependency-version: 6.6.1 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: rjsf ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [dompurify](https://github.com/cure53/DOMPurify) from 3.4.9 to 3.4.11. - [Release notes](https://github.com/cure53/DOMPurify/releases) - [Commits](cure53/DOMPurify@3.4.9...3.4.11) --- updated-dependencies: - dependency-name: dompurify dependency-version: 3.4.11 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.19.3 to 1.19.4. - [Release notes](https://github.com/sparklemotion/nokogiri/releases) - [Changelog](https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md) - [Commits](sparklemotion/nokogiri@v1.19.3...v1.19.4) --- updated-dependencies: - dependency-name: nokogiri dependency-version: 1.19.4 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…8011) Bumps [concurrent-ruby](https://github.com/ruby-concurrency/concurrent-ruby) from 1.3.6 to 1.3.7. - [Release notes](https://github.com/ruby-concurrency/concurrent-ruby/releases) - [Changelog](https://github.com/ruby-concurrency/concurrent-ruby/blob/master/CHANGELOG.md) - [Commits](ruby-concurrency/concurrent-ruby@v1.3.6...v1.3.7) --- updated-dependencies: - dependency-name: concurrent-ruby dependency-version: 1.3.7 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
|
Encountered many issues relating to Git, moved all of my changes to new PR |
Proposed Changes
(Describe your changes here. Also describe the motivation for your changes: what problem do they solve, or how do they improve the application or codebase? If this pull request fixes an open issue, use a keyword to link this pull request to the issue.)
tablefolder to include case sensitive filtering along side searching:case_sensitive_search_filterfilter.jsxto allow this component to be displayed when filterVariant: "case-sensitive-text" is usedsearch_filter.jsxaria-label definitionI18n.t("table.search")column.columnDef.headerfull_namecolumn usessearch_filter.jsxfor its search bar component. However, previous tests forgraders_manager.tsxexpected a search bar with the qualities:{name: ${I18n.t("search")} Name. With the previous definition, only the aria-label${I18n.t("search")}appears when runningscreen.debug(). Mimicking the previous implementation forcaseSensitiveTextFilterintable_helpers.jsx, allows all frontend tests to run and fixes the missing information in the aria-label.getSelectedRows()andresetSelection()<Table>isCaseSensitiveattribute to statetoggleCaseSensitivityfunction togroup_namecolumn's meta-section to allow the filter component to update caseSensitivity.Screenshots of your changes (if applicable)
BeforeAfter
Associated documentation repository pull request (if applicable)
Type of Change
(Write an
Xor a brief description next to the type or types that best describe your changes.)Checklist
(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the
[ ]into a[x]in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)Before opening your pull request:
After opening your pull request:
Questions and Comments
(Include any questions or comments you have regarding your changes.)
Small Note:
filter.jsxinsteadVery important question:
<Table>componentinitialStatedefinition means that they cannot change, even if the props being passed in are changing (Correct me if I'm wrong).Please feel free to ask about a specific component. I ended up removing many of the previous functions to make my implementation more similar to Lizzie's and to 'mock' the functionality of the previous implementation.
Am I good to start migrating the Annotations table? I'm kind of interested in pursuing another part of the codebase/doing something different. I'll let you know if I have anything specific in mind.